Skip to content

Skip a libcxx test for upcoming compiler changes#6165

Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
StephanTLavavej:escalator
Apr 3, 2026
Merged

Skip a libcxx test for upcoming compiler changes#6165
StephanTLavavej merged 3 commits intomicrosoft:mainfrom
StephanTLavavej:escalator

Conversation

@StephanTLavavej
Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej commented Mar 17, 2026

This is a reverse mirror of @Codiferous's MSVC-PR-720700 implementing WG21-P2564R3 "consteval Needs To Propagate Up" (aka Immediate Escalation). This increases compiler memory consumption, which is a problem for the accursed x86-hosted toolset.

@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 17, 2026 11:18
@StephanTLavavej StephanTLavavej added the test Related to test code label Mar 17, 2026
@github-project-automation github-project-automation Bot moved this to Initial Review in STL Code Reviews Mar 17, 2026
@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews Mar 17, 2026
@AlexGuteniev
Copy link
Copy Markdown
Contributor

We currently do native AArm64 compilation and cross compilation. Can do the same for x86?
The memory skips tend to accumulate.

@StephanTLavavej
Copy link
Copy Markdown
Member Author

We could easily configure GitHub to use the x64-hosted x86-targeting cross-compiler, but the MSVC-internal test harness is not so easily malleable.

@StephanTLavavej StephanTLavavej moved this from Final Review to Merging in STL Code Reviews Mar 18, 2026
@StephanTLavavej
Copy link
Copy Markdown
Member Author

Resolved adjacent-add merge conflict the same way that Cody did (with 3 newlines).

@StephanTLavavej StephanTLavavej merged commit da06be8 into microsoft:main Apr 3, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Apr 3, 2026
@StephanTLavavej StephanTLavavej deleted the escalator branch April 3, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Related to test code

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants