Skip to content

Fix CodeQL warnings after _wsetlocale() changes #6179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanTLavavej merged 2 commits into from
Mar 27, 2026
+3 −0
Merged

Fix CodeQL warnings after _wsetlocale() changes #6179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ed77e0
Suppress CodeQL warnings.
StephanTLavavej Mar 23, 2026
0d8d580
Suppress an additional line, just in case.
StephanTLavavej Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stl/inc/xlocinfo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,12 @@ public:

template <class _Elem2 = _Elem, enable_if_t<is_same_v<_Elem2, char>, int> = 0>
void _From_wide(const wchar_t* const _Right) noexcept {
// CodeQL [SM02986] We are intentionally storing `wchar_t*` as `char*` due to ABI, see GH-5781
if (reinterpret_cast<wchar_t*>(_Myptr) != _Right) { // new value, discard old and copy new
_Tidy();

if (_Right) { // new is not empty, copy it
// CodeQL [SM02986] We are intentionally storing `wchar_t*` as `char*` due to ABI, see GH-5781
_Myptr = reinterpret_cast<char*>(_STD _Ntcts_dup_dbg(_Right));
}
}
Expand Down
1 change: 1 addition & 0 deletions stl/src/locale0.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ void __CLRCALL_PURE_OR_CDECL _Locinfo::_Locinfo_dtor(_Locinfo* pLocinfo) { // de
// so reinterpret_cast is not reliable.
_wsetlocale(LC_ALL, L"");
} else {
// CodeQL [SM02986] We are intentionally storing `wchar_t*` as `char*` due to ABI, see GH-5781
_wsetlocale(LC_ALL, reinterpret_cast<const wchar_t*>(pLocinfo->_Oldlocname._C_str()));
}
}
Expand Down