Skip to content

Use _WIN64 test where applicable#6183

Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
AlexGuteniev:win64
Mar 27, 2026
Merged

Use _WIN64 test where applicable#6183
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
AlexGuteniev:win64

Conversation

@AlexGuteniev
Copy link
Copy Markdown
Contributor

Follow up to #6160

Use _WIN64 test instead of _M_IX86 test where it looks consistent with previous usages:

  • In bit functions, where it tests for native 64-bit bit intrinsics availability
  • In atomics, where it tests for native 64-bit interlocked intrinsics availability

Keep _M_IX86 when it means something else.
There are places where it means calling conventions or name mangling, for example.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner March 25, 2026 06:41
@github-project-automation github-project-automation Bot moved this to Initial Review in STL Code Reviews Mar 25, 2026
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Mar 25, 2026
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Mar 25, 2026
@StephanTLavavej
Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Mar 26, 2026
@StephanTLavavej StephanTLavavej merged commit 11ada44 into microsoft:main Mar 27, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Mar 27, 2026
@StephanTLavavej
Copy link
Copy Markdown
Member

Thanks for making the codebase more consistent! 📈 😻 🎉

@AlexGuteniev AlexGuteniev deleted the win64 branch March 27, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants