Skip to content

<__msvc_threads_core.hpp>: Revert alignas changes that broke mutex and condition_variable for /clr#6188

Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
StephanTLavavej:clr-mutex
Mar 31, 2026
Merged

<__msvc_threads_core.hpp>: Revert alignas changes that broke mutex and condition_variable for /clr#6188
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
StephanTLavavej:clr-mutex

Conversation

@StephanTLavavej
Copy link
Copy Markdown
Member

We merged #5811 which is about to ship in MSVC Build Tools 14.51, but it's causing major user heartburn: DevCom-11059932 VSO-2841023 "C++ toolset 14.51.36014 Preview alignment changes breaks C++/CLI code".

This cleanup would have been nice to have, but we need to revert it until the /clr alignas bugs VSO-1659383 and VSO-2616030 are fixed.

@StephanTLavavej StephanTLavavej added the bug Something isn't working label Mar 28, 2026
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 28, 2026 19:22
@github-project-automation github-project-automation Bot moved this to Initial Review in STL Code Reviews Mar 28, 2026
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews Mar 28, 2026
@StephanTLavavej
Copy link
Copy Markdown
Member Author

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

@StephanTLavavej StephanTLavavej moved this from Final Review to Merging in STL Code Reviews Mar 31, 2026
@StephanTLavavej StephanTLavavej merged commit 01f2c04 into microsoft:main Mar 31, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Mar 31, 2026
@StephanTLavavej StephanTLavavej deleted the clr-mutex branch March 31, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants