Skip to content

Toolset update: MSVC Compiler 19.52.36405.1, Clang 22.1.3#6296

Merged
StephanTLavavej merged 40 commits into
microsoft:mainfrom
StephanTLavavej:toolset-update
May 28, 2026
Merged

Toolset update: MSVC Compiler 19.52.36405.1, Clang 22.1.3#6296
StephanTLavavej merged 40 commits into
microsoft:mainfrom
StephanTLavavej:toolset-update

Conversation

@StephanTLavavej
Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej commented May 21, 2026

STL-ASan-CI passed; it had been failing for ARM64 since the previous toolset update #6260 and is now fixed by @zacklj89's MSVC-PR-731943 "[ARM64][ASan] Fix interception in jump tables" merged 2026-04-27.

StephanTLavavej and others added 30 commits May 18, 2026 12:10
For example, libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp has:

```cpp
// We test the cartesian product, so we sometimes compare differently signed types
// ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-sign-compare
// ADDITIONAL_COMPILE_FLAGS(character-conversion-warnings): -Wno-character-conversion
```
LLVM-62096 was reportedly fixed in Clang 21, but I can't remove this workaround yet.
All positive except for `P0896R4_ranges_iterator_machinery` adding a space in `ranges::iter_move (&f)(42)`.
See GH 5717, warning C4127 was removed by MSVC-PR-646313 on 2025-06-25.

The name `_Would_overflow` still provides value, keep it.
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner May 21, 2026 12:00
Copilot AI review requested due to automatic review settings May 21, 2026 12:00
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label May 21, 2026
@github-project-automation github-project-automation Bot moved this to Initial Review in STL Code Reviews May 21, 2026

This comment was marked as resolved.

This was unexpectedly passing for x86, but still failing for other architectures.
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews May 21, 2026
@StephanTLavavej

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej moved this from Final Review to Merging in STL Code Reviews May 21, 2026
@StephanTLavavej
Copy link
Copy Markdown
Member Author

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

Copilot AI review requested due to automatic review settings May 23, 2026 15:16
@StephanTLavavej
Copy link
Copy Markdown
Member Author

I had to push an additional commit to drop Clang ASan configs.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 119/147 changed files
  • Comments generated: 0 new

@StephanTLavavej StephanTLavavej merged commit 1f932bc into microsoft:main May 28, 2026
49 checks passed
@StephanTLavavej StephanTLavavej deleted the toolset-update branch May 28, 2026 21:56
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Related to repository automation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants