Skip to content

Enable ability for force override disabling SF node #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arudell merged 1 commit into from
May 22, 2026
+8 −3
Merged

Enable ability for force override disabling SF node #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/modules/SdnDiag.NetworkController.SF.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2986,6 +2986,8 @@ function Disable-SdnServiceFabricNode {
Specifies the name of a Service Fabric node. The cmdlet disables the node that you specify.
.PARAMETER Credential
Specifies a user account that has permission to perform this action. The default is the current user.
.PARAMETER Force
Specifies that the cmdlet should override any restrictions that would prevent the action from completing.
.EXAMPLE
PS> Disable-SdnServiceFabricNode -NetworkController 'NC01' -Credential (Get-Credential) -NodeName 'Node01'
#>
Expand All @@ -3001,7 +3003,10 @@ function Disable-SdnServiceFabricNode {
[Parameter(Mandatory = $false)]
[System.Management.Automation.PSCredential]
[System.Management.Automation.Credential()]
$Credential = [System.Management.Automation.PSCredential]::Empty
$Credential = [System.Management.Automation.PSCredential]::Empty,

[Parameter(Mandatory = $false)]
[System.Management.Automation.SwitchParameter]$Force
)

$stopWatch = [System.Diagnostics.Stopwatch]::StartNew()
Expand Down Expand Up @@ -3034,8 +3039,8 @@ function Disable-SdnServiceFabricNode {
# check to see if the service fabric cluster is healthy before we disable the node
# if the cluster is not healthy, then we cannot disable the node
$isClusterHealthy = Confirm-SdnServiceFabricHealthy -NetworkController $NetworkController -Credential $Credential -ErrorAction Stop
if (-NOT $isClusterHealthy) {
"Service Fabric Cluster is not healthy, cannot disable $($fabricNode.NodeName)" | Trace-Output -Level:Warning
if (-NOT $isClusterHealthy -and -NOT $Force) {
"Service Fabric Cluster is not healthy, cannot disable $($fabricNode.NodeName). Use -Force to override" | Trace-Output -Level:Warning
return
}

Expand Down
Loading