Skip to content

Update to Windows App SDK 1.4.230913002 & WinUIEx 2.3.2#4712

Merged
pratikone merged 12 commits intomicrosoft:mainfrom
Mysterious-Dev:wasdk-1.4
Nov 10, 2023
Merged

Update to Windows App SDK 1.4.230913002 & WinUIEx 2.3.2#4712
pratikone merged 12 commits intomicrosoft:mainfrom
Mysterious-Dev:wasdk-1.4

Conversation

@Mysterious-Dev
Copy link
Copy Markdown
Contributor

@Mysterious-Dev Mysterious-Dev commented Aug 30, 2023

PR checklist

Quick summary of changes

This PR update Windows App SDK to 1.4.230822000

Which issue does this PR relate to?

n/a

Applies to the following platforms:

  • WinUI
  • WPF
  • UWP

All is in the title ^^.

https://www.nuget.org/packages/Microsoft.WindowsAppSDK/1.4.230822000

https://github.com/dotMorten/WinUIEx/releases/tag/v2.3

@JasonWei512
Copy link
Copy Markdown

JasonWei512 commented Sep 8, 2023

https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/stable-channel#known-issues
In Windows App SDK 1.4, the min/max/close caption buttons for ExtendsContentIntoTitleBar = true are now drawn by AppWindow rather than XAML.
TitlebarHelper needs to be updated, because now the titlebar color is set like this:

App.MainWindow.AppWindow.TitleBar.BackgroundColor = ...
App.MainWindow.AppWindow.TitleBar.ButtonHoverBackgroundColor = ...

@Mysterious-Dev Mysterious-Dev changed the title Update to Windows App SDK 1.4.230822000 Update to Windows App SDK 1.4.230913002 Sep 20, 2023
@Mysterious-Dev
Copy link
Copy Markdown
Contributor Author

Well, I've got the beginnings of a fix for that, I'll keep looking at it over the next few days to push the changes ^^.

@Mysterious-Dev
Copy link
Copy Markdown
Contributor Author

Mysterious-Dev commented Sep 23, 2023

@bpulliam @pratikone @mikebattista

Well, I think this PR is ready for review ^^

@pratikone
Copy link
Copy Markdown
Contributor

Hi, thanks for the patience. For some time, I have been on-and-off investigating and working on this crash issue. #4707

this is the reason, I am not been able to test this out this change because it could have ripple effects. Also my machine state is entirely broken because of that. Given it is a iterative change, I think it can wait. We anyways need the crash to be fixed before next version of Template Studio can get released

@Mysterious-Dev
Copy link
Copy Markdown
Contributor Author

Hi, thanks for the patience. For some time, I have been on-and-off investigating and working on this crash issue. #4707

this is the reason, I am not been able to test this out this change because it could have ripple effects. Also my machine state is entirely broken because of that. Given it is a iterative change, I think it can wait. We anyways need the crash to be fixed before next version of Template Studio can get released

Well, now that #4707 is closed, I think we can get on with updating TemplateStudio for WASDK 1.4 ^^.

Copy link
Copy Markdown
Contributor

@pratikone pratikone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience. I have reviewed this PR. Only minor changes are needed else it looks good. Once done, it can be merged and I will trigger newer version of template studio binary

@Mysterious-Dev
Copy link
Copy Markdown
Contributor Author

Mysterious-Dev commented Nov 1, 2023

Thanks for the patience. I have reviewed this PR. Only minor changes are needed else it looks good. Once done, it can be merged and I will trigger newer version of template studio binary

@pratikone It's done, btw I also updated WinUIEx to 2.3.2 ^^.

@Mysterious-Dev Mysterious-Dev changed the title Update to Windows App SDK 1.4.230913002 Update to Windows App SDK 1.4.230913002 & WinUIEx 2.3.2 Nov 1, 2023
@pratikone pratikone merged commit 52d63a4 into microsoft:main Nov 10, 2023
@Mysterious-Dev Mysterious-Dev deleted the wasdk-1.4 branch November 10, 2023 18:31
@pratikone
Copy link
Copy Markdown
Contributor

thanks for additional change. I have merged your PR. Will get a release binary out soon

@Mysterious-Dev
Copy link
Copy Markdown
Contributor Author

thanks for additional change. I have merged your PR. Will get a release binary out soon

Glad to have helped (all tests passed btw) ^^.

@pratikone
Copy link
Copy Markdown
Contributor

New version of Template Studio has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants