Skip to content

Comments

changes for spotify since feb 2026:#1923

Merged
robgruen merged 6 commits intomicrosoft:mainfrom
bmerkle:spotify-API-changes-feb-2026
Feb 18, 2026
Merged

changes for spotify since feb 2026:#1923
robgruen merged 6 commits intomicrosoft:mainfrom
bmerkle:spotify-API-changes-feb-2026

Conversation

@bmerkle
Copy link
Contributor

@bmerkle bmerkle commented Feb 15, 2026

  • limit parameter has changed from 50 to 10 (otherwise we get API error now)
  • search for music titles has been improved to contain also special characters.

Note:

  • a spotify premium account is necessary to use the spoifty via API
  • therefore it is good, that we have localPlayer as alternative to spoify player

- limit parameter has changed from 50 to 10 (otherwise we get API error now)
- search for music titles has been improved to contain also special characters.

Note:
- a spotify premium account is necessary to use the spoifty via API
- therefore it is good, that we have localPlayer as alternative to spoify player
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Spotify player integration to accommodate recent Spotify API changes effective February 2026. The changes primarily address two issues: a reduction in the maximum allowed limit parameter for search queries, and improved handling of special characters in search terms through updated URL encoding.

Changes:

  • Reduced search query limit parameter from 50 (and 20 for playlists) to 10 across all search functions to comply with new Spotify API restrictions
  • Added required market parameter ("US") to getArtistTopTracks endpoint
  • Refactored getUrlWithParams to use standard percent-encoding (encodeURIComponent) instead of application/x-www-form-urlencoded (URLSearchParams) for proper special character handling

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
ts/packages/agents/player/src/search.ts Updated limit parameter from 50 to 10 in 6 search functions (searchArtists, searchAlbums, findArtistTracksWithGenre, expandMovementTracks, findTracksWithGenre, findTracks)
ts/packages/agents/player/src/client.ts Updated limit parameter to 10 for searchTracks (50→10) and searchForPlaylists (20→10)
ts/packages/agents/player/src/endpoints.ts Added market parameter to getArtistTopTracks; refactored getUrlWithParams to use encodeURIComponent for correct special character encoding

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… maintainability

limitMax is 50 for API calls

searchResultLimits is 10 fetches fewer results since these are targeted searches where only the top matches matter
@bmerkle bmerkle temporarily deployed to development-fork February 17, 2026 23:53 — with GitHub Actions Inactive
@bmerkle bmerkle temporarily deployed to development-fork February 17, 2026 23:53 — with GitHub Actions Inactive
@robgruen robgruen added this pull request to the merge queue Feb 18, 2026
Merged via the queue into microsoft:main with commit 4168ef0 Feb 18, 2026
15 of 17 checks passed
steveluc added a commit that referenced this pull request Feb 18, 2026
…ocal manifest paths

- Remove console.log [GRAMMAR] diagnostics from grammarStore.ts (debug() calls remain)
- Fix Spotify setVolume URL: remove stray ?volume_percent from base URL that caused
  double query param after getUrlWithParams was rewritten in PR #1923
- Fix playerLocal manifest to use agents/playerLocal/dist/... path convention
  matching getPackageFilePath expectations

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants