changes for spotify since feb 2026:#1923
Merged
robgruen merged 6 commits intomicrosoft:mainfrom Feb 18, 2026
Merged
Conversation
- limit parameter has changed from 50 to 10 (otherwise we get API error now) - search for music titles has been improved to contain also special characters. Note: - a spotify premium account is necessary to use the spoifty via API - therefore it is good, that we have localPlayer as alternative to spoify player
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Spotify player integration to accommodate recent Spotify API changes effective February 2026. The changes primarily address two issues: a reduction in the maximum allowed limit parameter for search queries, and improved handling of special characters in search terms through updated URL encoding.
Changes:
- Reduced search query limit parameter from 50 (and 20 for playlists) to 10 across all search functions to comply with new Spotify API restrictions
- Added required market parameter ("US") to getArtistTopTracks endpoint
- Refactored getUrlWithParams to use standard percent-encoding (encodeURIComponent) instead of application/x-www-form-urlencoded (URLSearchParams) for proper special character handling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ts/packages/agents/player/src/search.ts | Updated limit parameter from 50 to 10 in 6 search functions (searchArtists, searchAlbums, findArtistTracksWithGenre, expandMovementTracks, findTracksWithGenre, findTracks) |
| ts/packages/agents/player/src/client.ts | Updated limit parameter to 10 for searchTracks (50→10) and searchForPlaylists (20→10) |
| ts/packages/agents/player/src/endpoints.ts | Added market parameter to getArtistTopTracks; refactored getUrlWithParams to use encodeURIComponent for correct special character encoding |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
robgruen
reviewed
Feb 17, 2026
… maintainability limitMax is 50 for API calls searchResultLimits is 10 fetches fewer results since these are targeted searches where only the top matches matter
steveluc
added a commit
that referenced
this pull request
Feb 18, 2026
…ocal manifest paths - Remove console.log [GRAMMAR] diagnostics from grammarStore.ts (debug() calls remain) - Fix Spotify setVolume URL: remove stray ?volume_percent from base URL that caused double query param after getUrlWithParams was rewritten in PR #1923 - Fix playerLocal manifest to use agents/playerLocal/dist/... path convention matching getPackageFilePath expectations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: