Fix shell_and_cli CI: command backstack CSS selector and LLM request timeout#2046
Merged
robgruen merged 2 commits intodev/robgruen/glasswormfrom Mar 23, 2026
Merged
Conversation
- Fix CSS selector in chatView.ts: change `.chat-message-container-user:not(.history)` to `:not(.history) > .chat-message-container-user` so that the history filter checks the parent wrapper (where the .history class is actually applied in initializeChatHistory) rather than the user message element itself. This fixes the `command backstack` test failure where old session messages like `@exit` incorrectly appeared in the backstack. - Add optional timeout parameter to sendUserRequestAndWaitForCompletion (default 90s vs old 30s hardcoded). Fixes `create_update_clear_list` timeout failures where LLM-routed requests take longer than 30s on Windows CI. - Increase Playwright global test timeout from 300s to 600s to accommodate the listAgent test's 8 LLM-routed requests each with up to 90s timeout. Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/TypeAgent/sessions/cc1f6aa4-aa85-4558-8315-98a9c00255d3
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow shell_and_cli
Fix shell_and_cli CI: command backstack CSS selector and LLM request timeout
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent test failures in the
shell_and_cli (windows-latest)CI job: thecommand backstacktest picks up stale@exithistory entries, and thecreate_update_clear_listtest times out waiting for LLM-routed agent responses.CSS selector bug —
command backstacktestinitializeChatHistoryadds.historyto the parent wrapper elements (direct children of the scroll container), not to.chat-message-container-userelements themselves. The backstack query was filtering on the wrong element:Without this fix,
@exitmessages saved from previous test sessions are not excluded from the backstack, causing "Expected@history, Received@exit".Timeout —
create_update_clear_listtestsendUserRequestAndWaitForCompletionhad a hardcoded 30 s timeout. The listAgent test sends 8 natural-language requests that each require multi-agent LLM routing by the dispatcher — considerably heavier than the direct shell commands used by other tests. On Windows CI this routing consistently exceeded 30 s.timeoutparameter tosendUserRequestAndWaitForCompletion(default 90 s, backward-compatible).Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.