Fix TypeScript build errors in agent-dispatcher package#2051
Merged
robgruen merged 2 commits intodev/robgruen/mcp_non_blocking_loadingfrom Mar 23, 2026
Merged
Conversation
Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/TypeAgent/sessions/b859fc0f-3ea0-4ea8-9865-e548e01b6a4c
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow build_ts
Fix TypeScript build errors in agent-dispatcher package
Mar 23, 2026
robgruen
approved these changes
Mar 23, 2026
fc2e97e
into
dev/robgruen/mcp_non_blocking_loading
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
agent-dispatcherpackage failed to build due to several TypeScript type errors introduced by recent API changes that weren't propagated to all call sites.CompletionGroupsreturn type mismatch (configCommandHandlers.ts)CommandHandler.getCompletionwas updated to returnPromise<CompletionGroups>(wrapped object withgroupsproperty), but 7 implementations still returnedPromise<CompletionGroup[]>:Missing properties on
CommandHandlerContext(commandHandlerContext.ts)Three properties used in
command.tsanddispatcher.tswere missing from the type definition:currentAbortSignal: AbortSignal | undefinedactiveRequests: Map<string, AbortController>displayLog: DisplayLogAdded to the type and initialized in the context factory (
undefined,new Map(), andawait DisplayLog.load(persistDir)respectively).Wrong callback return type in
configureGrammarGeneration(commandHandlerContext.ts)The callback passed to
configureGrammarGenerationreturned astring(file path) but the signature requires(schemaName: string) => ParsedActionSchema. Also referenced the non-existentactionConfig.compiledSchemaFilePathfield. Fixed to load and parse the.pas.jsonfile:Non-existent
compiledSchemaFilePathonActionConfig(appAgentManager.ts)Same dead field access; replaced with
config.schemaFilePath?.endsWith(".pas.json")check.Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.