Fix TS2339 build error: tokens does not exist on ParsedCommandParams#2055
Merged
robgruen merged 2 commits intodev/robgruen/mcp_non_blocking_loadingfrom Mar 23, 2026
Conversation
…dCommandParams Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/TypeAgent/sessions/aa430ef3-42f5-43eb-8b7c-641bc3b7e232
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow build_package_shell
Fix TS2339 build error: Mar 23, 2026
tokens does not exist on ParsedCommandParams
robgruen
approved these changes
Mar 23, 2026
237a56f
into
dev/robgruen/mcp_non_blocking_loading
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build_package_shellCI job was failing becausegetMcpCommandHandlerTableinmcpAgentProvider.tsaccessedparams.tokens, which only exists on the internalParseParamsResult<T>type (dispatcher package), not on the publicParsedCommandParams<T>from@typeagent/agent-sdk.Changes
mcpAgentProvider.ts: Replaceparams.tokenswith an explicit collection of arg values fromparams.args, keyed by theArgDefinitionspassed to the outer function (preserving definition order):runcallback parameter type fromParsedCommandParams<{}>toParsedCommandParams<ParameterDefinitions>to match theCommandHandlerinterface.ParameterDefinitionsto the import from@typeagent/agent-sdk.Original prompt
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.