fix: re-enable agent greeting to unblock shell integration tests#2063
Merged
robgruen merged 2 commits intodev/robgruen/glasswormfrom Mar 24, 2026
Conversation
…tion tests The default agentGreeting setting was changed to false, which removed the mock greeting that previously warmed up the dispatcher's command pipeline before tests ran. Without this warm-up, the first NL request sent by tests (e.g. "create a shopping list") timed out because the dispatcher's commandLock and agent infrastructure hadn't been initialised yet. Setting agentGreeting back to true ensures @Greeting --mock is processed via processShellRequest before test commands arrive, so the dispatcher is ready to handle agent requests within the 90-second test timeout. Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/TypeAgent/sessions/a2559bde-8b59-4757-b2ef-241e4c6e6922
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow shell_and_cli
fix: re-enable agent greeting to unblock shell integration tests
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
create_update_clear_listPlaywright test was timing out because the dispatcher's command pipeline was never warmed up before test commands arrived. The root cause:agentGreetingwas changed tofalsein the default shell settings, which silently removed the@greeting --mockstartup command that previously ranprocessShellRequestonce before any test request, initialising thecommandLock,updateSummary, and agent infrastructure.Without that warm-up, the first NL request ("create a shopping list") had to absorb all cold-start cost itself and consistently exceeded the 90-second
waitForAgentMessagetimeout.Change
ts/packages/shell/src/preload/shellSettingsType.ts— restoreagentGreetingdefault totrueWith the greeting re-enabled,
@greeting --mock(injected because tests always pass--mock-greetings) runs throughprocessShellRequestat startup. The dispatcher is warm by the time test commands arrive, and NL requests complete well within the timeout.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.