Skip to content

fix: re-enable agent greeting to unblock shell integration tests#2063

Merged
robgruen merged 2 commits intodev/robgruen/glasswormfrom
copilot/fix-github-actions-workflow-92387e00-f5d9-4dfb-a673-71b3e72bf622
Mar 24, 2026
Merged

fix: re-enable agent greeting to unblock shell integration tests#2063
robgruen merged 2 commits intodev/robgruen/glasswormfrom
copilot/fix-github-actions-workflow-92387e00-f5d9-4dfb-a673-71b3e72bf622

Conversation

Copy link
Contributor

Copilot AI commented Mar 24, 2026

The create_update_clear_list Playwright test was timing out because the dispatcher's command pipeline was never warmed up before test commands arrived. The root cause: agentGreeting was changed to false in the default shell settings, which silently removed the @greeting --mock startup command that previously ran processShellRequest once before any test request, initialising the commandLock, updateSummary, and agent infrastructure.

Without that warm-up, the first NL request ("create a shopping list") had to absorb all cold-start cost itself and consistently exceeded the 90-second waitForAgentMessage timeout.

Change

  • ts/packages/shell/src/preload/shellSettingsType.ts — restore agentGreeting default to true
// Before
agentGreeting: false,

// After
agentGreeting: true,

With the greeting re-enabled, @greeting --mock (injected because tests always pass --mock-greetings) runs through processShellRequest at startup. The dispatcher is warm by the time test commands arrive, and NL requests complete well within the timeout.

Original prompt

Fix the failing GitHub Actions workflow shell_and_cli (windows-latest, 22)
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 68284995089
Job URL: https://github.com/microsoft/TypeAgent/actions/runs/23468206726/job/68284995089


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…tion tests

The default agentGreeting setting was changed to false, which removed the
mock greeting that previously warmed up the dispatcher's command pipeline
before tests ran. Without this warm-up, the first NL request sent by tests
(e.g. "create a shopping list") timed out because the dispatcher's
commandLock and agent infrastructure hadn't been initialised yet.

Setting agentGreeting back to true ensures @Greeting --mock is processed
via processShellRequest before test commands arrive, so the dispatcher is
ready to handle agent requests within the 90-second test timeout.

Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/TypeAgent/sessions/a2559bde-8b59-4757-b2ef-241e4c6e6922
Copilot AI changed the title [WIP] Fix failing GitHub Actions workflow shell_and_cli fix: re-enable agent greeting to unblock shell integration tests Mar 24, 2026
Copilot AI requested a review from robgruen March 24, 2026 04:27
@robgruen robgruen marked this pull request as ready for review March 24, 2026 04:38
@robgruen robgruen merged commit 66384c5 into dev/robgruen/glassworm Mar 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants