refactor: extract grammarCompletion.ts from grammarMatcher.ts#2084
Merged
curtisman merged 1 commit intomicrosoft:mainfrom Mar 26, 2026
Merged
Conversation
Move the completion system (matchGrammarCompletion, GrammarCompletionResult, and all supporting completion functions) into a dedicated grammarCompletion.ts module. Update exports in index.ts, fix imports in nfaCompletion.ts and testUtils.ts, and update documentation references across README.md, NFA_README.md, and actionGrammar.md.
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the completion system (
matchGrammarCompletion,GrammarCompletionResult, and all supporting completion functions) into a dedicatedgrammarCompletion.tsmodule.Changes
packages/actionGrammar/src/grammarCompletion.ts— contains all completion logic previously ingrammarMatcher.tsindex.tsto re-export from the new modulenfaCompletion.tsandtestUtils.tsREADME.md,NFA_README.md, anddocs/architecture/actionGrammar.mdto reference the new file