Restore RemoteSearchMenuUI for Electron overlay search menu#2134
Merged
curtisman merged 1 commit intomicrosoft:mainfrom Apr 5, 2026
Merged
Restore RemoteSearchMenuUI for Electron overlay search menu#2134curtisman merged 1 commit intomicrosoft:mainfrom
curtisman merged 1 commit intomicrosoft:mainfrom
Conversation
In Electron, use RemoteSearchMenuUI (rendered in a separate WebContentsView) so the completion menu can overlay beyond the chat view bounds. Falls back to LocalSearchMenuUI in non-Electron environments. This was removed in microsoft#1933 when inline ghost text completions were added.
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
Member
Author
|
@steveluc FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
RemoteSearchMenuUIusage in Electron so the completion menu renders in a separateWebContentsViewthat can overlay beyond the chat view bounds.When PR #1933 added inline ghost text completions, it replaced the
RemoteSearchMenuUI/LocalSearchMenuUIbranching withInlineSearchMenuUI/LocalSearchMenuUI, leavingRemoteSearchMenuUIas dead code. The remote search menu infrastructure (IPC handlers,electronSearchMenuUI.ts,searchMenuView.ts, preload bindings) was never removed and remains fully intact.Changes
packages/shell/src/renderer/src/search.ts: When not in inline mode, useRemoteSearchMenuUIin Electron (viaisElectron()check) and fall back toLocalSearchMenuUIin non-Electron environments. This matches the original behavior before Add inline ghost text completions and fix NFA wildcard completion #1933.