defaultAgentProvider: grammar/construction test updates#2232
Merged
Conversation
…date grammar spec Now that diacritic-insensitive matching is in place, add assertion that the normalized-request match produces the same actions as the original. Also update grammar.spec.ts to use normalizeParamString instead of toLowerCase for the lower-case match test. Mark TODOs done. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tion tests The lowercase match finds the right action but string parameter values come back lowercased, so we validate the action name rather than the full action equality. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Agent-Logs-Url: https://github.com/microsoft/TypeAgent/sessions/0847446a-48bb-4e55-b728-defdfdb4ad27 Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/TypeAgent/sessions/1c8fa0d3-b228-4f4a-86b9-78d197164943 Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2210.