Skip to content

defaultAgentProvider: grammar/construction test updates#2232

Merged
robgruen merged 6 commits intomainfrom
dev/robgruen/TODO/actionGrammar
Apr 23, 2026
Merged

defaultAgentProvider: grammar/construction test updates#2232
robgruen merged 6 commits intomainfrom
dev/robgruen/TODO/actionGrammar

Conversation

@robgruen
Copy link
Copy Markdown
Collaborator

  • Add action-name validation for lower-case request matching in construction round-trip

Split from #2210.

robgruen and others added 4 commits April 22, 2026 14:02
…date grammar spec

Now that diacritic-insensitive matching is in place, add assertion that
the normalized-request match produces the same actions as the original.
Also update grammar.spec.ts to use normalizeParamString instead of
toLowerCase for the lower-case match test. Mark TODOs done.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tion tests

The lowercase match finds the right action but string parameter values
come back lowercased, so we validate the action name rather than the
full action equality.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Agent-Logs-Url: https://github.com/microsoft/TypeAgent/sessions/0847446a-48bb-4e55-b728-defdfdb4ad27

Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
@robgruen robgruen temporarily deployed to development-fork April 22, 2026 23:37 — with GitHub Actions Inactive
@robgruen robgruen added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit 1593bed Apr 23, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants