player: Spotify caching, year ranges, user-data completions#2235
Merged
player: Spotify caching, year ranges, user-data completions#2235
Conversation
The playlist branch was an empty stub — playlists were silently omitted from completions. Now returns all playlist names in API order (no timestamp field is available on PlaylistObjectSimplified). Adds jest infrastructure and userData.spec.ts with 5 tests covering playlist flag off/on, undefined playlists, combined track+playlist output, and track timestamp sorting. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Module-level map avoids repeated API calls for the same genre across different invocations. Also removes stale spelunker/eval TODO entry (already implemented via eval-config.json file reading). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When users filter by year range (e.g. "year:1990-2000"), the tokenizer splits the input into "1990 - 2000". The Year constraint now detects this pattern and performs an inclusive range check against the track's release year rather than a substring match. Also removes stale TODO.md entries for queryInterface.ts and pdfQNAInteractiveApp.ts that were already implemented. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Agent-Logs-Url: https://github.com/microsoft/TypeAgent/sessions/2957f24a-a43c-45f3-8c32-24188f43a28a Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findTracksWithGenreplayer/userData: return playlist names ingetUserDataCompletionsSplit from #2210.