Skip to content

fix(ts): avoid pnpm workspace bin link warnings before build#2328

Merged
curtisman merged 2 commits into
microsoft:mainfrom
curtisman:fix-pnpm-workspace-bin-shims
May 12, 2026
Merged

fix(ts): avoid pnpm workspace bin link warnings before build#2328
curtisman merged 2 commits into
microsoft:mainfrom
curtisman:fix-pnpm-workspace-bin-shims

Conversation

@curtisman
Copy link
Copy Markdown
Member

@curtisman curtisman commented May 11, 2026

Summary

fix(ts): pnpm workspace bin link warnings

  • Switch several workspace package bin entries from dist/* targets to checked-in shim entrypoints under bin/
  • Add shim scripts for action-grammar, mcp-plan-validation, coder-wrapper, and kp-test
  • Shims delegate to built dist/* files when present and print a clear build instruction if not yet built

docs: WSL2 setup clarification

  • Add "Setup Node native module build tools" step (sudo apt install -y make build-essential) before the clone/build steps

Why

pnpm i creates executable symlinks during install. For workspace packages whose bin points directly to dist/* outputs, install warns when those compiled files don't exist yet (fresh clone before first build). The shims fix this by providing a stable, always-present entrypoint.

The WSL2 docs change makes clear that make and build-essential are required before running pnpm i / pnpm run build, preventing native module build failures.

Validation

  • Ran pnpm i --ignore-scripts in ts workspace — bin-link warnings no longer reproduced for these packages

@curtisman curtisman enabled auto-merge May 11, 2026 22:36
@curtisman curtisman force-pushed the fix-pnpm-workspace-bin-shims branch from 067d978 to cee361b Compare May 11, 2026 22:46
@curtisman curtisman force-pushed the fix-pnpm-workspace-bin-shims branch from cee361b to 1e1cc26 Compare May 11, 2026 22:50
@curtisman curtisman force-pushed the fix-pnpm-workspace-bin-shims branch from 1e1cc26 to d80cfbd Compare May 11, 2026 22:50
@curtisman curtisman requested a deployment to development-fork May 12, 2026 01:07 — with GitHub Actions Waiting
@curtisman curtisman requested a deployment to development-fork May 12, 2026 01:07 — with GitHub Actions Waiting
@curtisman curtisman added this pull request to the merge queue May 12, 2026
Merged via the queue into microsoft:main with commit bc7656c May 12, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant