Conversation
Contributor
umeshma
commented
Aug 24, 2024
umeshma
commented
- Make a verbs a special term
- Improve TermFilter schema for better results
- Matching on verbs and indirect object terms
robgruen
added a commit
that referenced
this pull request
Mar 5, 2026
The `build_package_shell` CI job was failing because a dependabot bump of `mailparser` from `3.9.0` → `3.9.3` in `ts/packages/memory/conversation/package.json` was not accompanied by a lockfile update, causing `pnpm install --frozen-lockfile` to abort. ## Changes - **`ts/pnpm-lock.yaml`** — regenerated via `pnpm install --no-frozen-lockfile` to record `mailparser@3.9.3` as the resolved version, bringing the lockfile back in sync with the manifest > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `www.electronjs.org` > - Triggering command: `/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node /home/REDACTED/work/TypeAgent/TypeAgent/ts/node_modules/.pnpm/@electron+rebuild@4.0.3/node_modules/@electron/rebuild/lib/module-type/node-gyp/worker.js` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/microsoft/TypeAgent/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Fix the failing GitHub Actions workflow build_package_shell (ubuntu-latest, 22) > Analyze the workflow logs, identify the root cause of the failure, and implement a fix. > Job ID: 65783204282 > Job URL: https://github.com/microsoft/TypeAgent/actions/runs/22690110859/job/65783204282 </details> <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/microsoft/TypeAgent/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
robgruen
added a commit
that referenced
this pull request
Mar 19, 2026
Dependabot bumped `fast-xml-parser` from `5.3.8` → `5.5.6` in `ts/examples/docuProc/package.json` without regenerating the lockfile, causing CI to fail with `ERR_PNPM_OUTDATED_LOCKFILE` on `pnpm install --frozen-lockfile`. ## Changes - **`ts/pnpm-lock.yaml`**: Regenerated via `pnpm install --no-frozen-lockfile` to sync with updated `package.json` - Replaces `fast-xml-parser@5.3.8` entries with `5.5.6` - Adds new transitive deps introduced by `5.5.6`: `fast-xml-builder@1.1.4`, `path-expression-matcher@1.1.3` > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `www.electronjs.org` > - Triggering command: `/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node /home/REDACTED/work/TypeAgent/TypeAgent/ts/node_modules/.pnpm/@electron+rebuild@4.0.3/node_modules/@electron/rebuild/lib/module-type/node-gyp/worker.js` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/microsoft/TypeAgent/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Fix the failing GitHub Actions workflow build_ts (ubuntu-latest, 20) > Analyze the workflow logs, identify the root cause of the failure, and implement a fix. > Job ID: 67807514082 > Job URL: https://github.com/microsoft/TypeAgent/actions/runs/23313717014/job/67807514082 </details> <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/microsoft/TypeAgent/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
robgruen
added a commit
that referenced
this pull request
Apr 3, 2026
Dependabot bumped `electron` to `40.8.4` in `ts/packages/shell/package.json` but did not regenerate `ts/pnpm-lock.yaml`, causing `pnpm install --frozen-lockfile` to fail in CI with `ERR_PNPM_OUTDATED_LOCKFILE`. ## Changes - **`ts/pnpm-lock.yaml`**: Regenerated via `pnpm install --no-frozen-lockfile` to align the lockfile's electron specifier (`40.6.0` → `40.8.4`) with `packages/shell/package.json` > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `www.electronjs.org` > - Triggering command: `/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node /home/REDACTED/work/TypeAgent/TypeAgent/ts/node_modules/.pnpm/@electron+rebuild@4.0.3/node_modules/@electron/rebuild/lib/module-type/node-gyp/worker.js` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/microsoft/TypeAgent/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Fix the failing GitHub Actions workflow build_package_shell (macos-latest, 22) > Analyze the workflow logs, identify the root cause of the failure, and implement a fix. > Check run ID: 69799281248 > Job URL: https://github.com/microsoft/TypeAgent/actions/runs/23931502972/job/69799281248 </details> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: robgruen <25374553+robgruen@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
…te split (#2165) `test:local` was still picking up tests that depend on external services and API keys via runtime gating (`testIf`/`describeIf`). This PR reclassifies those suites so service-dependent tests run under `test:live` instead of local runs. - **Reclassify service-dependent suites to live** - Renamed fully API-key-gated test files from `*.spec.ts` to `*.test.ts` in: - `packages/aiclient` - `packages/knowPro` - `packages/knowledgeProcessor` - `packages/memory/conversation` - `packages/memory/storage` - `packages/memory/website` - Result: these suites are no longer selected by local `*.spec` patterns. - **Add explicit live test scripts in affected packages** - Added `test:live` scripts with `--testPathPattern=".*[.]test[.]js"` to each affected package so workspace-level `pnpm run test:live` includes them. - **Align website online alias with live routing** - Updated `packages/memory/website/package.json`: - `test:online` now delegates to `test:live` (instead of `test:local`) to match `.online` suite intent. ```json { "scripts": { "test:local": "pnpm run jest-esm --testPathPattern=\".*[.]spec[.]js\"", "test:live": "pnpm run jest-esm --testPathPattern=\".*[.]test[.]js\"" } } ``` > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `ip-api.com` > - Triggering command: `/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --no-warnings --experimental-vm-modules /home/REDACTED/work/TypeAgent/TypeAgent/ts/node_modules/.pnpm/jest-worker@29.7.0/node_modules/jest-worker/build/workers/processChild.js Agen�� ignore src/preload dules/.bin/sh electron.vite.prsh --logLevel error node k/Ty�� /bin/jest.js '--testPathPattern=.*[.]spec[.]js' 1 dules/.bin/sh gnore dist r uname` (dns block) > - Triggering command: `/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --no-warnings --experimental-vm-modules /home/REDACTED/work/TypeAgent/TypeAgent/ts/node_modules/.pnpm/jest-worker@29.7.0/node_modules/jest-worker/build/workers/processChild.js /hom�� build src/preload k/_temp/ghcca-node/node/bin/node electron.vite.prsh --logLevel .bin/node node k/Ty�� /bin/jest.js '--testPathPattern=.*[.]spec[.]js' 1 dules/.bin/sh gnore dist ct/node_modules/.bin/node node` (dns block) > - Triggering command: `/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --no-warnings --experimental-vm-modules /home/REDACTED/work/TypeAgent/TypeAgent/ts/node_modules/.pnpm/jest-worker@29.7.0/node_modules/jest-worker/build/workers/processChild.js Agen�� build src/preload uid-build electron.vite.prsh --logLevel error node Agen�� /bin/jest.js '--testPathPattern=.*[.]spec[.]js' 1 odules/pnpm/dist/node-gyp-bin/sh src/**/*.txt dist in/copyfiles node` (dns block) > - `www.electronjs.org` > - Triggering command: `/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/TypeAgent/TypeAgent/ts/node_modules/.pnpm/@electron+rebuild@4.0.3/node_modules/@electron/rebuild/lib/module-type/node-gyp/worker.js` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/microsoft/TypeAgent/settings/copilot/coding_agent) (admins only) > > </details> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: curtisman <12101885+curtisman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.