Auto elevate with getKeys#8
Merged
curtisman merged 2 commits intomicrosoft:mainfrom Aug 12, 2024
curtisman:getKeys
Merged
Conversation
robgruen
reviewed
Aug 12, 2024
robgruen
reviewed
Aug 12, 2024
robgruen
approved these changes
Aug 12, 2024
curtisman
added a commit
to curtisman/TypeAgent
that referenced
this pull request
Mar 26, 2026
- Replace expect()-based completionResultsEqual with node:util isDeepStrictEqual (no Jest runtime dependency) - Renumber invariants contiguously (1-12), removing redundant ones: old microsoft#7 (separatorMode undefined when empty), microsoft#8 (separatorMode optional at mpl=0), microsoft#10 (closedSet true for keywords, derivable from #2), microsoft#12 (dup of #3) - Reformat invariant tables as definition-list paragraphs for readability - Add regression test for directionSensitive recompute when openWildcard=true (validates the guard change from prior commit) - Add completion.md invariant cross-references in test comments - Fix stale actionGrammar.md claim about recompute skip conditions
curtisman
added a commit
to curtisman/TypeAgent
that referenced
this pull request
Mar 29, 2026
- Remove redundant from>0 guard in isSeparatorOnlyGap (to>from suffices) - Remove redundant anchor!==maxPrefixLength conjunct at Phase B - Use 'forward|backward' union type instead of string for direction param - Add consolidated invariant index (#1-microsoft#8) at top of test utils - Renumber invariants: single-result #1-#2, cross-direction #3-microsoft#7, truncated-forward microsoft#8 - Replace mpl abbreviation with matchedPrefixLength in comments - Standardize on 'fallback' terminology (was mixed fallthrough/fallback) - Extract normalizeCompletionResult helper alongside completionResultsEqual - Fix stale test name that still referenced old expected completions - Fix 'Backup failed' wording to name the function explicitly
curtisman
added a commit
to curtisman/TypeAgent
that referenced
this pull request
Mar 29, 2026
Align test code and doc numbering so both use the same continuous sequence matching the order invariants appear in completion.md: #1-#2 per-result (assertSingleResultInvariants) #3 truncated-forward idempotency (assertTruncatedForwardInvariant) microsoft#4-microsoft#8 cross-direction (assertCrossDirectionInvariants) microsoft#9-microsoft#10 field-specific (doc-only) microsoft#11-microsoft#15 merge invariants (doc-only) Update cross-references in actionGrammar.md and grammarCompletion.ts to match.
curtisman
added a commit
to curtisman/TypeAgent
that referenced
this pull request
Mar 30, 2026
directionSensitive means 'would backward at P give different results than forward?' — a property of the position P, not relative to any caller-supplied floor. - Simplify computation: P > 0 (was P != minPrefixLength) - Fix invariant cross-queries (microsoft#5-microsoft#8): pass undefined instead of minPrefixLength to re-invocations — the definition is about unconstrained calls at input[0..P] - Update decision tree in actionGrammar.md and completion.md - Update test expectation: minPrefixLength=5 with P=5 is now directionSensitive=true (P > 0)
curtisman
added a commit
to curtisman/TypeAgent
that referenced
this pull request
Apr 4, 2026
- Fix mergeSepMode comment: 'at position' → 'at position - 1' - Expand effectiveTrailingSep JSDoc with specific recomputation details - Clarify 'wildcard-at-EOI string states' → 'states with a string next-part' - Change computeRangeNeedsSep return type to tri-state (needsSep/noSep/drop) - actionGrammar.md: 'Fixed:' → 'Handled via:' in summary table - actionGrammar.md: plain-text three-way table → proper markdown table - completion.md: add inline invariant descriptions (#3, microsoft#7, microsoft#8, microsoft#9, microsoft#13) - grammarStore.ts: add cross-reference to filterSepConflicts - Test: 'wins over optional' → 'is strongest merged mode'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the elevate script to be reused by
getKeysto JIT elevate.