Skip to content

Conversation

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Apr 4, 2024

In #207, I made it so that hatch would create a .venv in the repository root. The reason was to make common scenarios work better for editors (most which currently don't understand hatch).

Still, lots of people don't use Hatch, and in #215, @pamelafox pointed out that it's nice to have control over this stuff. So this PR makes it possible to use use pip directly with our pyproject.toml. To do so, dev-time dependencies for TypeChat, along with dependencies for our examples, are moved into their own respective arrays in optional-dependencies.

Since pip allows you to install "extras" (see here, here, and here), developers can just write something like the following:

cd TypeChat/python
python -v venv ../.venv
source ../.venv/bin/activate
pip install .[dev,examples]

python/README.md Outdated
Or with a custom virtual environment:

```sh
git clone https://github.com/microsoft/TypeChat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the stuff I would typically put in CONTRIBUTING.md since most developers won't need it, once this is on Pypi. Your call though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants