Add support for parsing deprecated property in member nodes #2231
+5
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
reviewed
Nov 4, 2025
inputfiles/patches/events.kdl
Outdated
|
|
||
| dictionary KeyboardEventInit { | ||
| member charCode deprecated=#true | ||
| member keyCode deprecated=#true |
There was a problem hiding this comment.
I intend to put only event types in events.kdl, let's put this in uievents.kdl per https://w3c.github.io/uievents/#interface-keyboardevent
|
LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
jakebailey
previously approved these changes
Nov 4, 2025
|
LGTM |
|
Sorry @saschanaz, this PR has merge conflicts. They'll need to be fixed before this can be merged. |
jakebailey
approved these changes
Nov 5, 2025
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2053