Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
421 changes: 419 additions & 2 deletions baselines/dom.generated.d.ts

Large diffs are not rendered by default.

421 changes: 419 additions & 2 deletions baselines/ts5.5/dom.generated.d.ts

Large diffs are not rendered by default.

421 changes: 419 additions & 2 deletions baselines/ts5.6/dom.generated.d.ts

Large diffs are not rendered by default.

421 changes: 419 additions & 2 deletions baselines/ts5.9/dom.generated.d.ts

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions inputfiles/patches/html.kdl
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,12 @@ interface-mixin WindowEventHandlers {
// The unload event is not reliable, consider visibilitychange or pagehide events
property onunload deprecated=#true
}

// Blink and Gecko support precommit but BCD is not updated yet
// https://bugzilla.mozilla.org/show_bug.cgi?id=1970123
interface NavigationPrecommitController exposed=Window {
method redirect exposed=Window
}
interface NavigationTransition {
property committed exposed=Window
}
24 changes: 7 additions & 17 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 27 additions & 14 deletions src/build/patches.ts
Original file line number Diff line number Diff line change
Expand Up @@ -296,25 +296,38 @@ function handleMethod(child: Node): DeepPartial<OverridableMethod> {
}
}

// Determine the actual signature object
const signatureObj: DeepPartial<Signature> = {
param: params,
...(typeNode
? handleTyped(typeNode)
: {
const type = typeNode
? handleTyped(typeNode)
: child.properties?.returns
? {
type: string(child.properties?.returns),
subtype: undefined,
}),
};
}
: null;

let signature: OverridableMethod["signature"];
const signatureIndex = child.properties?.signatureIndex;
if (typeof signatureIndex == "number") {
signature = { [signatureIndex]: signatureObj };
} else {
signature = [signatureObj];
if ((params.length || signatureIndex) && !type) {
throw new Error("A method signature requires a type");
}

let signature: OverridableMethod["signature"] = [];
if (type) {
// Determine the actual signature object
const signatureObj: DeepPartial<Signature> = {
param: params,
...type,
};
if (typeof signatureIndex == "number") {
signature = { [signatureIndex]: signatureObj };
} else {
signature = [signatureObj];
}
}
return { name, signature };
return {
name,
signature,
...optionalMember("exposed", "string", child.properties.exposed),
};
}

/**
Expand Down