Migrate Crypto to KDL #2277
Merged
Migrate Crypto to KDL #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
reviewed
Dec 8, 2025
inputfiles/patches/crypto-public.kdl
Outdated
| @@ -0,0 +1,14 @@ | |||
| removals { | |||
Collaborator
There was a problem hiding this comment.
this should go to webauthn.kdl which already exists
saschanaz
reviewed
Dec 8, 2025
inputfiles/patches/webcrypto.kdl
Outdated
| encapsulateKey // No implementation as of 2025-09 | ||
| } | ||
|
|
||
| dictionary KeySystemTrackConfiguration { |
Collaborator
There was a problem hiding this comment.
this one goes to media-capabilities.kdl
inputfiles/patches/webcrypto.kdl
Outdated
| member encryptionScheme // Gecko only as of 2025-05 | ||
| } | ||
|
|
||
| dictionary CredentialRequestOptions { |
Collaborator
There was a problem hiding this comment.
this one is to webauthn.kdl
Collaborator
|
It's useful to use https://respec.org/xref/?term=PublicKeyCredentialRequestOptions to see where things belong to. |
Contributor
Author
|
Thank you very much @saschanaz, this will help me a lot, I didn't know about it |
Contributor
Author
|
I have update it |
Removed an empty line before the JsonWebKey dictionary.
Collaborator
|
LGTM |
Contributor
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.