Skip to content

Remove redundant fetch declarations#691

Merged
sandersn merged 2 commits intomicrosoft:masterfrom
saschanaz:dedupe-fetch
Jun 4, 2019
Merged

Remove redundant fetch declarations#691
sandersn merged 2 commits intomicrosoft:masterfrom
saschanaz:dedupe-fetch

Conversation

@saschanaz
Copy link
Copy Markdown
Collaborator

Fixes #634

@sandersn sandersn merged commit 6a58a0e into microsoft:master Jun 4, 2019
@danvk
Copy link
Copy Markdown

danvk commented Jul 17, 2019

What's the process for these changes making their way into the TypeScript repo? I see many changes here but none to lib.dom.d.ts since February.

@sandersn
Copy link
Copy Markdown
Member

  1. npm run build in this repo
  2. copy files from generated/ into Typescript/src/lib/ -- you should see many updates from this repo there since June at least.
  3. On a release, generate a new LKG -- last known good -- that includes lib.dom.d.ts, plus all the typescript binaries, etc.

Step (3) hasn't happened for TS 3.6 yet.

@saschanaz saschanaz deleted the dedupe-fetch branch July 17, 2019 21:10
@danvk
Copy link
Copy Markdown

danvk commented Jul 18, 2019

I see, there is TypeScript/lib and TypeScript/src/lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated function declaration: fetch

3 participants