Add null types to optional IDB query parameters#701
Merged
sandersn merged 2 commits intomicrosoft:masterfrom Jun 6, 2019
Merged
Add null types to optional IDB query parameters#701sandersn merged 2 commits intomicrosoft:masterfrom
sandersn merged 2 commits intomicrosoft:masterfrom
Conversation
4 tasks
Member
|
You should be able to merge from master to fix this build error. |
sandersn
approved these changes
Jun 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/TypeScript#31490
This PR adds
nullas a valid type to all IndexedDB API methods that accept an optional query param followed by another argument.It also standardizes on the name "query" everywhere (previously it was sometimes called "query" and sometimes called "range"), as "query" is what's used in Web IDL in the spec.
Note: I was getting an error when running the build step that appears to be unrelated to my changes (it fails on master as well). I'm not sure what (if anything) I should do about that.