Skip to content

Fix a little typo on readme #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 1 commit into from
Jun 4, 2019
Merged

Fix a little typo on readme #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ In order to make the tests pass, please update the baseline as well in any pull
It's recommended to first check which spec the wrong type belongs to. Say we are to update `IntersectionObserver` which belongs to [`Intersection Observer`](https://www.w3.org/TR/intersection-observer/) spec, and then we can do:

1. First check we have the spec name `Intersection Observer` in `inputfiles/idlSources.json`. If not, add it.
2. Run `npm run fetch-idl "Intersection Observer" && num run build && npm run baseline-accept`.
2. Run `npm run fetch-idl "Intersection Observer" && npm run build && npm run baseline-accept`.

If the above didn't fix the type issues, we can fix them via json files as a last resort.
There are three json files that are typically used to alter the type generation: `addedTypes.json`, `overridingTypes.json`, and `removedTypes.json`.
Expand Down