tsconfig.json settings not taking effect

[musicist288]

Using master on Sublime Text 3 - Ubuntu 14.04.

I have a project with the tsconfig.json file

{
    "compilerOptions": {
        "module": "commonjs",
        "removeComments": true
    },
    "files": [/* files listed here */]
}

but I get the error: Cannot compile external modules unless the '--module' flag is provided

I replaced the tsserver directory with same files from typescript 1.5.0-beta and it seems to work just fine. Are these suppose to be in sync?

[ddotlic]

Same here, I'm getting weird warnings about accessors only avaible when targeting ES5, which I am (based on my tsconfig.json)

Interestingly, this worked fine until this afternoon. What I did today is I installed VS 2015RC but made sure that it did not put its copy of tsc on a path before node one which I've been using for days without issues.

The other thing I did was update to the latest code and it's entirely possible that this commit borked it: 8e2b009 (tsserver.js changed, thanks @musicist288 for the hint)

I'm on Windows 8.1 but apparently this is irrelevant.

[ddotlic]

I'm seeing significant difference between tsserver as shipped with 1.5 beta and the one in this plugin - is this normal?

Out of curiosity, why not use tsserver as shipped (by TypeScript itself, installed through npm), it's in the path by definition (just next to tsc)?

[zhengbli]

Sorry a change I made yesterday was intended to incorporate several bug fixes made after 1.5 beta, but I committed a locally built version of tsserver.js instead. Changed them back in #182

[zhengbli]

The reason why we haven't used the tsserver in the npm package may be we intended to have a different release schedule. However we are definitely considering the option as it would make the experience more consistent.

[ddotlic]

@zhengbli At this point we the users don't really care this way or another, but the one in the master of this project just plain doesn't work 😃 , hence this bug report.

[aminroosta]

any progress on this ?

[zhengbli]

The changes are in now. @ddotlic @aminroosta could you give it a shot? Thanks!

[ddotlic]

Pulled, restarted, no issues. Though it doesn't occur on every restart, so we'll have to wait and see.

[aminroosta]

@zhengbli works great. :)

[musicist288]

Working here.

On Wed, May 6, 2015 at 2:53 PM amin roosta notifications@github.com wrote:

@zhanbos https://github.com/zhanbos works greak. :)

—
Reply to this email directly or view it on GitHub
#180 (comment)
.