Skip to content

Conversation

@zhengbli
Copy link
Contributor

@zhengbli zhengbli commented May 4, 2015

No description provided.

@steveluc
Copy link
Contributor

steveluc commented May 4, 2015

Looks good. We have typescript_auto_format on the key bindings; do we also need it on the class (I think it won't do any harm either way)?

    {
        "keys": [ ";" ],
        "command": "typescript_format_on_key",
        "args": { "key": ";" },
        "context": [
            { "key": "selection_empty", "operator": "equal", "operand": true, "match_all": true },
            { "key": "setting.typescript_auto_format", "operator": "equal", "operand": true },
            { "key": "selector", "operator": "equal", "operand": "source.ts" }
        ]
    }

@zhengbli
Copy link
Contributor Author

zhengbli commented May 4, 2015

The reason I added this is for now there is no way to disable the auto format if the user doesn't want that (related issue #159)

@zhengbli
Copy link
Contributor Author

zhengbli commented May 4, 2015

Oh now I see what you mean. This is redundant if we already have that in key configs. Closing.

@zhengbli zhengbli closed this May 4, 2015
@zhengbli zhengbli changed the title Add option "typescript_auto_format" to turn off auto format Add option "typescript_auto_format" to turn off auto format + reconfiguring host format settings when they are changed May 4, 2015
@zhengbli zhengbli reopened this May 4, 2015
@zhengbli
Copy link
Contributor Author

zhengbli commented May 4, 2015

Reopen because it also contained issue fixes.

zhengbli added a commit that referenced this pull request May 4, 2015
Reconfiguring host format settings when they are changed
@zhengbli zhengbli merged commit f13f673 into microsoft:master May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants