Update Enums.md: Fix wrong description#2911
Merged
jakebailey merged 1 commit intomicrosoft:v2from Jul 31, 2023
Merged
Conversation
0xScratch
approved these changes
Jul 31, 2023
Member
|
Presumably, #2868 was in fact wrong? |
jakebailey
approved these changes
Jul 31, 2023
Member
jakebailey
left a comment
There was a problem hiding this comment.
Yeah, I think I misread the other PR, as did the other author.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in this section
Union enums and enum member types
In that example, we first checked whether x was not E.Foo. If that check succeeds, then our || will short-circuit, and the body of the ‘if’ will run. However, if the check didn’t succeed,
then x can only be E.Bar, so it doesn’t make sense to see whether it’s equal to E.Bar.when the first check didn’t succeed, then x is
E.Foo, so it doesn’t make sense to seex !== E.Bar