[SALSA] @callback's @param tags should not require names

[TheLarkInn]

TypeScript Version: 2.9.0-dev.20180518

Search Terms:
@callback @params duplicate identifier error
Code

/**
 * @callback ModuleSortPredicate
 * @param {Module} a
 * @param {Module} b
 * @returns {-1|0|1}
 */

/**
 * @callback ModuleFilterPredicate
 * @param {Module}
 * @param {Chunk}
 * @returns {boolean}
 */

/**
 * @callback ChunkFilterPredicate
 * @param {Chunk} c
 * @returns {boolean}
 */

Expected behavior:
No errors, or syntax highlighting errors.
Actual behavior:

lib/Chunk.js:44:18 - error TS1003: Identifier expected.
44  * @param {Chunk}
lib/Chunk.js:44:18 - error TS2300: Duplicate identifier '(Missing)'.
44  * @param {Chunk}

Playground Link:

Related Issues:

Here is an image of it in action. I'm not sure if it is interaction with other things at the same time. I'm happy to pull information for you @sandersn. If you goto webpack/webpack#feature/type-compiler-compilation-save branch you can go to those lines of the code and test it as well.

[sandersn]

The problem is that @callback's @param tags require names, just like @param tags in a function's jsdoc. These names aren't really used; they just serve as documentation. But @callback isn't really needed either -- the whole thing serves as documentation.

Let me see if I can figure out what usejsdoc.org says, since @callback is their syntax.

[sandersn]

usejsdoc.org doesn't give any special rules for @param when used inside @callback, so the name is still technically required. We could allow the name to be optional since @callback uses positional matching for its parameters, but there's no guarantee other jsdoc tools would do the same.

[TheLarkInn]

I'm fine with adding them when it provides value. In some cases it isn't though. So I'm on board with the optional stuff.