The 'Convert to ES6 Module' in the TS language support has an aftereffect.

[andylizf]

Issue Type: Bug

I chose the IntelliSense 'Convert to ES6 Module' at the import statement, then I generated it, but failed. If I don't convert, it runs fine. I think the convert of IntelliSense should be equivalent, at least the result should not cause a error.

var commandExists = require("command-exists").sync
console.log(commandExists('C://MinGW//bin//g++.exe'))

VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 x 2195)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	3.92GB (0.59GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions: none

[mjbvz]

What error does it cause?

If this is for node, the error is expected currently since regular js files can't use import / export

[andylizf]

@mjbvz Yes, this is for node.

[mjbvz]

The conversion seems to be doing what it was designed to

Not sure if we can handle non-transpiled node code more gracefully, for example changing the file extension to .mjs for node. Any thoughts @Andy-MS?

[weswigham]

Even converting the extension to .mjs won't guarantee it works in node, since .mjs support in node is still experimental, at best (you need an experimental flag to use it and it doesn't work as it does with transpilers). You'd get consistent behavior from babel/webpack/@std/esm; but those all support es modules without changing the extension anyway. It's probably just not correct to over the refactoring for a JS file right now if this is an issue, since it only "works" if you're transpiling the JS in some way.

[andylizf]

@weswigham I suggest labeling its side effects right now, or simply deleting this intelligence - in node. Because this mistake after covert is too difficult to find out.