F12 go to definition get 2 same result

[KT-71]

Template info added by @mjbvz

TypeScript Version: 3.7.0-dev.20190913

Search Terms

• JavaScript
• Commonjs / node
• go to definition

Repo

1. Using the code below
2. Run go to definition on m1echo in the call m1.m1echo() inside m2.js

Original report below

---

// Win10(x64) + node js 10.16.3 + npm -v 6.9.0

// Peek m1echo/m2echo definition will get 2 SAME definitions

// index.js

const m1 = require('./m1.js');
const m2 = require('./m2.js');

m1.m1work();
m2.m2work();

// m1.js

module.exports = {};
const m2 = require('./m2.js');

module.exports.m1work = function () {
    console.log('m1.m2.echo = <' + m2.m2echo() + '>');
}
module.exports.m1echo = function () {
    return 'this m1.';
}

// m2.js

module.exports = {};
const m1 = require('./m1.js');

module.exports.m2work = function () {
    console.log('m2.m1.echo = <' + m1.m1echo() + '>');
}
module.exports.m2echo = function () {
    return 'this m2.';
}

[mjbvz]

Here's an example of the TS Server response:

[Trace  - 5:49:29 PM] <semantic> Response received: definitionAndBoundSpan (23). Request took 2 ms. Success: true 
Result: {
    "definitions": [
        {
            "file": "/Users/matb/projects/san/m1.js",
            "start": {
                "line": 7,
                "offset": 16
            },
            "end": {
                "line": 7,
                "offset": 22
            },
            "contextStart": {
                "line": 7,
                "offset": 1
            },
            "contextEnd": {
                "line": 7,
                "offset": 22
            }
        },
        {
            "file": "/Users/matb/projects/san/m1.js",
            "start": {
                "line": 7,
                "offset": 16
            },
            "end": {
                "line": 7,
                "offset": 22
            },
            "contextStart": {
                "line": 7,
                "offset": 25
            },
            "contextEnd": {
                "line": 9,
                "offset": 2
            }
        }
    ],
    "textSpan": {
        "start": {
            "line": 5,
            "offset": 39
        },
        "end": {
            "line": 5,
            "offset": 45
        }
    }
}

[RyanCavanaugh]

Closing language service bugs related to the 6.0 implementation. For more information, see #62827