commonjs nested re-exports are broken

[sandersn]

User tests compile with quite a few errors again. I haven't confirmed that this is the case on release-4.1, but I expect it is.

Follow-on to #40578, very likely a result of the PR that fixed that, plus the recent improvement to commonjs export aliasing.

[sandersn]

Here's a repro. This seems unlikely to be common outside prettier, but we still need to get this working for 4.1:

// @filename: forever.js
const hardline = { type: "Hard" }
module.exports = { hardline }

// @filename: mod1.js
module.exports = {
  nested: require('./forever')
}

// @filename: test.js
const { hardline } = require('./mod1').nested
hardline

Notably, there's only an error on the second use of hardline in test.js: the first one is fine. The problem so far is that hardline resolves to module.exports = { hardline }. Previously, this wasn't an alias, and type checking proceeded to resolve to const hardline in forever.js. However, the new export alias is incorrectly not resolved, so the call to resolveSymbol retrieves an alias and issues an error since it expected a value.