Deprecated tag support for JavaScript and TypeScript in overrides in children

[thernstig]

Issue Type: Feature Request

https://code.visualstudio.com/updates/v1_49#_deprecated-tag-support-for-javascript-and-typescript added the great @deprecated tag support which works great.

However, when extending a parent class that has a @deprecated method, that method is not shown with strikethrough in the child. It would be great if this was the case.

VS Code version: Code 1.53.2 (622cb03f7e070a9670c94bae1a45d78d7181fbd4, 2021-02-11T11:48:04.245Z)
OS version: Windows_NT x64 10.0.18363
Remote OS version: Linux x64 5.4.0-65-generic

[thernstig]

Also, the actual function itself in the parent where it is defined is not strike through, that would also be nice.

[mjbvz]

Please share code (as text) that demonstrates this problem

[thernstig]

Repro:

// father.js

class Father {
  constructor() {
    console.log('constructor');
  }

  /**
   * @returns {string} stuff
   */
  newFunction() {
    return 'new';
  }

  /**
   * @deprecated
   *
   * @returns {string} stuff
   */
  oldFunction() {
    return 'old';
  }
}

module.exports = { Father };

// child.js

const { Father } = require('./father');

class Child extends Father {
  /**
   * @returns {string} stuff
   */
  newFunction() {
    return 'new child';
  }

  /**
   * @returns {string} stuff
   */
  oldFunction() {
    return 'old child';
  }
}

module.exports = { Child };

Notice how oldFunction does not have strikethrough. Also, hovering that function in both the father and the child does not show it as strikethrough in the popup.

However, during autocompletion when writing the function name it properly shows as strikethrough:

[RyanCavanaugh]

This seems subjective? The base class method being deprecated doesn't necessarily imply the derived class method is too.

[thernstig]

True. I wonder what the best option is here. As can be seen in the IntelliSense it currently does use strikethrough.