New parameter implicit any error with latest nightly

[mjbvz]

Bug Report

from #52148 (comment)

🔎 Search Terms

• Implicit any
• parameter

🕗 Version & Regression Information

• This changed between versions 4.9.4 and 5.0.0-dev.20230111

⏯ Playground Link

https://www.typescriptlang.org/play?ts=5.0.0-dev.20230111#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXzDigxAElUBnDKdEAHgGEMcZ4QAPE1YC+VEAO7wAFADpxsAOYUAXPBoBPANoBdAJTwAvAD55qBQBp4AJTacQ3XuSo0wIACoKADvSYtt24ZhZy3MI+KiUrLwDHhUMMjeMAAKsFAAtiAkMBSMzDDaanLGANwAUPkcTiwY8FioKYhQdvCkALIWyADqLADWAEYWYAAW9jg4EABCsADyTtjh8ADe+fDz8MyDHWMTuJRyswvbSAPCKzByERWS2fDHqJJzCwC+BTeFkFAUvI2oLe1d6H0Dw7Az13mYHCGEi0WEgJ2ODW4TkDSarRgnW6P0GIxg40mlHgAB94GhQIgKiBgAZIRppvAHg98oQQMQyJRqLRhG8Pkivr1+mjYEYtgslhADpj1iF+Ttdjh9rAKfA4BhkDB8AdclTIdS1LkgA

💻 Code

declare function createInstance<Ctor extends new (...args: any[]) => any, R extends InstanceType<Ctor>>(ctor: Ctor, ...args: ConstructorParameters<Ctor>): R;

export interface IMenuWorkbenchToolBarOptions {
    toolbarOptions: {
        foo(bar: string): string
    };
}

class MenuWorkbenchToolBar {
    constructor(
        options: IMenuWorkbenchToolBarOptions | undefined,
    ) { }
}

createInstance(MenuWorkbenchToolBar, {
    toolbarOptions: {
        foo(bar) { return bar; } // error here
    }
});

🙁 Actual behavior

bar implicitly has an any type

🙂 Expected behavior

bar should be inferred to be a string

/cc @RyanCavanaugh

[jakebailey]

This seems unintentional:

fede84e85b49efb2ff8de6f707e67e9ac2ab2c1c is the first bad commit
commit fede84e85b49efb2ff8de6f707e67e9ac2ab2c1c
Author: Anders Hejlsberg <andersh@microsoft.com>
Date:   Fri Dec 16 13:47:10 2022 -0800

    `const` modifier on type parameters (#51865)

But, #51865 did also change how we do contextual types into a stack-like thing (so maybe something there).

@ahejlsberg

[ahejlsberg]

Hmm, yeah, the contextual type caching is a bit too aggressive here. Specifically, we can't always trust the contextual type cached by checkArrayLiteral or checkObjectLiteral when obtaining a contextual signature because we sometimes instantiate the type using inferences collected until that point. Pretty easy fix.