Remove experimental flag to cache for-of length checks. #2539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Jakefile src/compiler/commandLineParser.ts src/compiler/types.ts
Member
|
Were we just not seeing a perf improvement here? |
Contributor
|
@DanielRosenwasser yes, caching length of the array can be improve performance but it should be done on case-by-case basic since length of the array can be change as you iterate if elements were added\removed from the array during iteration. |
Contributor
|
👍 |
CyrusNajmabadi
added a commit
that referenced
this pull request
Mar 30, 2015
Remove experimental flag to cache for-of length checks.
Member
|
Sure, I get that, but I thought that was the reason it was put behind a flag. Either way this is fine. |
Contributor
|
@DanielRosenwasser flag is not fine grained enough, it will enable\disable caching for everything which might be incorrect. |
Member
|
I understand that and I would presume that the users of such a flag would understand that as well, though I can see why it might not be the best choice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.