Skip to content

Conversation

@mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Jul 11, 2018

No description provided.

Benjamin Lichtman and others added 30 commits June 29, 2018 17:12
createExportAssignment: parenthesize nested class or function expression
* Index signatures contribute properties to unions

This means that in a union like this:

```ts
type T = { foo: number } | { [s: string]: string }
```

`foo` is now a property of `T` with type `number | string`. Previously
it was not.

Two points of interest:

1. A readonly index signature makes the resulting union property readonly.
2. A numeric index signature only contributes number-named properties.

Fixes #21141

* Correctly handle numeric and symbol property names

1. Symbol-named properties don't contribute to unions.
2. Number-named properties should use the numeric index signature type,
if present, and fall back to the string index signature type, not the
other way round.
* get return type from `@type` tags

Previously, getJSDocReturnType did not check the `@type` tag for a type
node that has a return type. Now it does.

* Improve doc comment of getJSDocReturnType

* More type predicates in type guards!

* Update API baselines with new documentation (?!)
Link back to likely declarations in "did you mean...?" error messages
* Strip literal freshness from type queries

* Rename to fix typo
…#24258)

* Introduce truncation into node builder and symbol display part writer

* Change default maxa truncation length to 240

* Fancy truncation + higher hard limit
mhegazy and others added 27 commits July 9, 2018 17:26
Don't crash when an implicit rootDir constraint is violated under composite: true
…25522)

* getEditsForFileRename: Handle all projects and source-mapped files

* Update API (#24966)

* Use areEqual
…25538)

For performance reasons, we should always pass sourceFile to getChildren
if available.
Block scoped variables, classes and enums would issue a bogus
use-before-def error in jsdoc because name resolution always adds Value,
even when resolving a type.

Fixes #25097
Fix assert and check for module symbol
Use getEmitDeclarations instead of .declarations
* Increase span of unreachable code error

* Add a new diagnostic for each range of unreachable statements

* Update baselines
Caches the recursive directory watchers so we do not have to traverse and recreate more children watches
Report errors for module generation other than "commonjs" with --resolveJsonModule
* JSX closing tag completion: Include '>' if not already present

* Expand comment
@mhegazy mhegazy merged commit d5f4da6 into release-3.0 Jul 12, 2018
@mhegazy mhegazy deleted the mergeMaster7-10 branch July 12, 2018 18:30
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.