-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Merge master into release-3.0 #25572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and recreate more children watches Helps with #25018
createExportAssignment: parenthesize nested class or function expression
* Index signatures contribute properties to unions
This means that in a union like this:
```ts
type T = { foo: number } | { [s: string]: string }
```
`foo` is now a property of `T` with type `number | string`. Previously
it was not.
Two points of interest:
1. A readonly index signature makes the resulting union property readonly.
2. A numeric index signature only contributes number-named properties.
Fixes #21141
* Correctly handle numeric and symbol property names
1. Symbol-named properties don't contribute to unions.
2. Number-named properties should use the numeric index signature type,
if present, and fall back to the string index signature type, not the
other way round.
* get return type from `@type` tags Previously, getJSDocReturnType did not check the `@type` tag for a type node that has a return type. Now it does. * Improve doc comment of getJSDocReturnType * More type predicates in type guards! * Update API baselines with new documentation (?!)
Link back to likely declarations in "did you mean...?" error messages
* Strip literal freshness from type queries * Rename to fix typo
…#24258) * Introduce truncation into node builder and symbol display part writer * Change default maxa truncation length to 240 * Fancy truncation + higher hard limit
Don't crash when an implicit rootDir constraint is violated under composite: true
Block scoped variables, classes and enums would issue a bogus use-before-def error in jsdoc because name resolution always adds Value, even when resolving a type. Fixes #25097
Fix assert and check for module symbol
Use getEmitDeclarations instead of .declarations
* Increase span of unreachable code error * Add a new diagnostic for each range of unreachable statements * Update baselines
Make getSuggestion APIs internal.
Build script updates
…lveJsonModule Fixes #25517
Caches the recursive directory watchers so we do not have to traverse and recreate more children watches
Report errors for module generation other than "commonjs" with --resolveJsonModule
* JSX closing tag completion: Include '>' if not already present * Expand comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.