Skip to content

Support getOccurrences on the TS Server #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 9, 2015
Merged

Support getOccurrences on the TS Server #2666

merged 9 commits into from
Apr 9, 2015

Conversation

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Apr 8, 2015

No description provided.

mhegazy
mhegazy reviewed Apr 8, 2015
View reviewed changes
src/server/session.ts
Copy link
Contributor

@mhegazy mhegazy Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you are missing the actual handling of the command in onMessage

Copy link
Member Author

@DanielRosenwasser DanielRosenwasser Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, just sent that part out. I'm not that familiar with the server so I'm still getting a feel for things.

@steveluc
Copy link
Contributor

steveluc commented Apr 8, 2015

Get occurences and get references share the same return type. It would be good if they shared a return type in protocol.d.ts also.

@steveluc
Copy link
Contributor

steveluc commented Apr 8, 2015

You could make optional the lineText field in the ReferencesResponseItem and then use it for occurrences.

@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented Apr 8, 2015

On one hand, I agree that they are frankly similar and we'd be reusing code; on the other, I somewhat feel like we'd be conflating two concepts. Is lineText always included for a ReferencesResponseItem?

CyrusNajmabadi
CyrusNajmabadi reviewed Apr 8, 2015
View reviewed changes
tests/cases/fourslash/server/occurrences01.ts Outdated
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does 'false' mean?

mhegazy
mhegazy reviewed Apr 8, 2015
View reviewed changes
src/server/session.ts Outdated
Copy link
Contributor

@mhegazy mhegazy Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are using destructuring i would put it everywhere in this method for consistency.

@mhegazy
Copy link
Contributor

mhegazy commented Apr 8, 2015

👍

DanielRosenwasser added a commit that referenced this pull request Apr 9, 2015
@DanielRosenwasser
Merge pull request #2666 from Microsoft/occurrencesOnServer
4eb8c73 
Support getOccurrences on the TS Server
@DanielRosenwasser DanielRosenwasser merged commit 4eb8c73 into master Apr 9, 2015
@DanielRosenwasser DanielRosenwasser deleted the occurrencesOnServer branch April 9, 2015 01:11
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DanielRosenwasser @steveluc @mhegazy @CyrusNajmabadi @msftclas