Conversation
RyanCavanaugh
approved these changes
Feb 4, 2019
Member
Author
|
Ooops, I forgot to update baselines. I just did, for all the correct changes. Unfortunately, the test for over-large inferred reverse-mapped types now hits the inference cut off instead of succeeding as it did after the fix that it was added with. I need to decide if this is correct or not. |
mihailik
reviewed
Feb 5, 2019
| @@ -2176,6 +2214,7 @@ declare var BhxBrowser: { | |||
| new(): BhxBrowser; | |||
| }; | |||
|
|
|||
| /** The BiquadFilterNode interface represents a simple low-order filter, and is created using the AudioContext.createBiquadFilter() method. It is an AudioNode that can represent different kinds of filters, tone control devices, and graphic equalizers. */ | |||
Contributor
There was a problem hiding this comment.
Wouldn't it improve readability+quality to cut leading The BiquadFilterNode interface?
mihailik
reviewed
Feb 5, 2019
| @@ -2145,6 +2182,7 @@ declare var BaseAudioContext: { | |||
| new(): BaseAudioContext; | |||
| }; | |||
|
|
|||
| /** The beforeunload event is fired when the window, the document and its resources are about to be unloaded. */ | |||
Contributor
There was a problem hiding this comment.
Or here drop The beforeunload event is
mihailik
reviewed
Feb 5, 2019
| @@ -2190,6 +2229,7 @@ declare var BiquadFilterNode: { | |||
| new(context: BaseAudioContext, options?: BiquadFilterOptions): BiquadFilterNode; | |||
| }; | |||
|
|
|||
| /** A Blob object represents a file-like object of immutable, raw data. Blobs represent data that isn't necessarily in a JavaScript-native format. The File interface is based on Blob, inheriting blob functionality and expanding it to support files on the user's system. */ | |||
mihailik
reviewed
Feb 5, 2019
| interface CSS { | ||
| escape(value: string): string; | ||
| supports(property: string, value?: string): boolean; | ||
| } | ||
| declare var CSS: CSS; | ||
|
|
||
| /** An object implementing the CSSConditionRule interface represents a single condition CSS at-rule, which consists of a condition and a statement block. It is a child of CSSGroupingRule. */ |
Contributor
There was a problem hiding this comment.
Here a bit more complex: An object implementing the CSSConditionRule interface
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates from TSJS-lib-generator. Notably, this update includes JSDoc from MDN.