Skip to content

fix 38503. #39716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbuckton merged 4 commits into from
Feb 2, 2021
Merged

fix 38503. #39716

rbuckton merged 4 commits into from
Feb 2, 2021

Conversation

@ShuiRuTian
Copy link
Contributor

@ShuiRuTian ShuiRuTian commented Jul 23, 2020

Fixes #38503

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 23, 2020
@ShuiRuTian
Copy link
Contributor Author

ShuiRuTian commented Jul 23, 2020 •
edited
Loading 

##[error]node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts(961,60): error TS2339: Property 'GET /user/:migration_id/repositories' does not exist on type 'Endpoints'.
##[error]node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts(962,33): error TS2339: Property 'GET /user/:migration_id/repositories' does not exist on type 'Endpoints'.
##[error]node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts(987,31): error TS2339: Property 'GET /user/:migration_id/repositories' does not exist on type 'Endpoints'.
##[error]node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts(988,29): error TS2339: Property 'GET /user/:migration_id/repositories' does not exist on type 'Endpoints'.

seems something goes wrong.
Is it due to net connection? I thought the change would not cause this.......

@orta
Copy link
Contributor

orta commented Jul 23, 2020 •
edited
Loading

this should be fixed upstream: #39712

@ShuiRuTian
Copy link
Contributor Author

ShuiRuTian commented Aug 7, 2020

Friendly ping ~ @rbuckton

@ShuiRuTian
Copy link
Contributor Author

ShuiRuTian commented Aug 25, 2020

ping @rbuckton

@ShuiRuTian
Copy link
Contributor Author

ShuiRuTian commented Nov 10, 2020

up.

rbuckton
rbuckton suggested changes Feb 2, 2021
View reviewed changes
@rbuckton
Copy link
Contributor

rbuckton commented Feb 2, 2021

Thanks for the contribution!

@rbuckton rbuckton merged commit 3e28e29 into microsoft:master Feb 2, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rbuckton rbuckton rbuckton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rbuckton rbuckton

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fail to short circuit an undefined private class field with optional chaining

4 participants

@ShuiRuTian @orta @rbuckton @typescript-bot