Skip to content

fix(38283): Incorrect parse on static property followed by method #41127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

fix(38283): Incorrect parse on static property followed by method #41127

merged 1 commit into from
Nov 2, 2020

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Oct 16, 2020

Fixes #38283

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Oct 16, 2020
@sandersn
Copy link
Member

sandersn commented Oct 28, 2020

@DanielRosenwasser should this go in 4.1 or 4.2?

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Oct 28, 2020

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 28, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 37859aa. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 28, 2020 •
edited
Loading

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/88012/artifacts?artifactName=tgz&fileId=689D6E517F8ECAC83635890CCE0B6C9FF93673CA9A67D1B420FB502773C0C62F02&fileName=/typescript-4.1.0-insiders.20201028.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

@sandersn sandersn merged commit 056d01a into microsoft:master Nov 2, 2020
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 26, 2021
Closed
orta added a commit to orta/TypeScript that referenced this pull request Jun 29, 2021
@orta
Allow for class static vars to be called static - re: microsoft#41127
2ff3a38
@orta orta mentioned this pull request Jun 29, 2021
Merged
orta pushed a commit that referenced this pull request Oct 1, 2021
Allow for class static vars to be called static (#44813)
016d78b 
* Allow for class static vars to be called static - re: #41127

* Add the baselines
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@rbuckton rbuckton

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect parse on static property followed by method

5 participants

@a-tarasyuk @sandersn @DanielRosenwasser @typescript-bot @rbuckton