Fix completions crash on transient exported property named 'default'#42583
Merged
andrewbranch merged 2 commits intomicrosoft:masterfrom Feb 4, 2021
Merged
Fix completions crash on transient exported property named 'default'#42583andrewbranch merged 2 commits intomicrosoft:masterfrom
andrewbranch merged 2 commits intomicrosoft:masterfrom
Conversation
amcasey
approved these changes
Feb 4, 2021
Member
amcasey
left a comment
There was a problem hiding this comment.
These all seem like sensible changes, but it's not immediately obvious to me what was actually crashing. Maybe aliased.parent was undefined?
Member
Author
|
In this case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40991
Also includes a drive-by improvement to allow us to get a name for
defaultorexport=when the target is an identifier with parentheses, non-null assertions, type assertions, etc., instead of just a bare identifier.