Refactor params for interface #42652
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
| } | ||
|
|
||
| /* Declarations in interface implementations have their own symbol so we need to go to the interface declaration | ||
| to get the type from the method signature. */ |
There was a problem hiding this comment.
I don't understand which part gets the type from the method signature. Is it entryToDeclaration? getSymbolForInterfaceSignature only gets the symbol.
There was a problem hiding this comment.
changed comment.
| if (signature) { | ||
| const newSignatureParams = map(createNewParameters(signature, program, host), param => getSynthesizedDeepClone(param)); | ||
| replaceParameters(signature, newSignatureParams); | ||
| } | ||
| replaceParameters(functionDeclaration, newFunctionDeclarationParams); |
There was a problem hiding this comment.
Should these branches be mutually exclusive? This looks suspicious to me.
There was a problem hiding this comment.
If the signature is defined, that means we were able to connect the method declaration back to it. That is, functionDeclaration implements signature and both should be changed. The absence of signature simply means functionDeclaration does not implement a method declared elsewhere (that we know of).
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looks good enough to go in, although a test with unions might make sense if the code fix could be available.
| ////interface IBar { | ||
| //// method(x: number): void; | ||
| ////} | ||
| ////const x: IFoo & IBar = { |
There was a problem hiding this comment.
what happens with unions? Do we even get the error that triggers the codefix?
There was a problem hiding this comment.
There is a test refactorConvertParamsToDestructuredObject_interfaceNoUnion.ts:
https://github.com/microsoft/TypeScript/pull/42652/files#diff-bb37f20a7f9bacc80fda3468d1e6c808314c79f47e8f58dc3d55c7e3d5447360
It's a refactor so we just don't offer it.
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
4 participants
Fixes #30418 for interfaces and type literals.
Cases for which we do not offer the refactor: