Use a (hopefully) more efficient regex for matching jquery in the safelist#42653
Merged
weswigham merged 1 commit intomicrosoft:masterfrom Feb 4, 2021
Merged
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was flagged as a potential performance issue for files named like
jquery-99999999999999999999999999.js(or similar), which, while unlikely to occur in the wild, is probably simple enough for us to change the regex to avoid triggering (vs suppressing the codeQL result). I'm not 100% sure the new regex won't also have catastrophic backtracking, but I trust codeQL'll probably flag this PR if it does~