Expand extractSymbol ranges#42770
Merged
jessetrinity merged 6 commits intomicrosoft:masterfrom Feb 17, 2021
Merged
Conversation
Contributor
Author
|
cc @mjbvz |
Member
|
Does this resolve #41469 or is it just related? That issue seems to be about doing this for all refactorings. |
amcasey
suggested changes
Feb 16, 2021
Contributor
Author
|
I expect that #41469 only relates to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41469
When a refactor is invoked through a keyboard command we search a bit harder for the extract symbol refactor by treating the selected span as though it covers the tokens containing the start and end tokens.
That is, selecting
will be equivalent to selecting
for the purposes of offering the refactor to extract
bar + baz.I also separated out the unit tests into individual tests so we can tell them apart on failure.