Skip to content

Rewrite createTextWriter to buffer appends #44242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amcasey wants to merge 1 commit into from
Closed

Rewrite createTextWriter to buffer appends #44242

amcasey wants to merge 1 commit into from

Conversation

@amcasey
Copy link
Member

@amcasey amcasey commented May 24, 2021

A more ambitious version of #44241

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 24, 2021
@amcasey
Copy link
Member Author

amcasey commented May 24, 2021

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 24, 2021 •
edited
Loading

Heya @amcasey, I've started to run the perf test suite on this PR at 43bcc88. You can monitor the build here.

Update: The results are in!

@amcasey amcasey mentioned this pull request May 24, 2021
Closed
amcasey
amcasey commented May 25, 2021
View reviewed changes
amcasey
amcasey commented May 25, 2021
View reviewed changes
@typescript-bot
Copy link
Collaborator

typescript-bot commented May 25, 2021

@amcasey
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..44242

Metric master 44242 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 343,844k (± 0.02%) 343,957k (± 0.02%) +113k (+ 0.03%) 343,828k 344,079k
Parse Time 1.79s (± 0.49%) 1.81s (± 0.45%) +0.02s (+ 1.12%) 1.80s 1.83s
Bind Time 0.84s (± 0.83%) 0.84s (± 0.95%) -0.00s (- 0.36%) 0.82s 0.86s
Check Time 5.22s (± 0.42%) 5.24s (± 0.62%) +0.02s (+ 0.29%) 5.15s 5.31s
Emit Time 5.46s (± 0.87%) 5.83s (± 1.10%) +0.37s (+ 6.74%) 5.73s 5.99s
Total Time 13.32s (± 0.50%) 13.72s (± 0.65%) +0.40s (+ 3.03%) 13.61s 13.95s
Compiler-Unions - node (v10.16.3, x64)
Memory used 200,297k (± 0.07%) 200,431k (± 0.04%) +133k (+ 0.07%) 200,293k 200,677k
Parse Time 0.78s (± 0.51%) 0.79s (± 0.85%) +0.01s (+ 0.77%) 0.77s 0.80s
Bind Time 0.53s (± 1.76%) 0.53s (± 1.55%) +0.01s (+ 1.14%) 0.51s 0.55s
Check Time 7.59s (± 0.70%) 7.57s (± 0.63%) -0.02s (- 0.29%) 7.44s 7.65s
Emit Time 2.25s (± 1.71%) 2.27s (± 0.98%) +0.02s (+ 1.11%) 2.24s 2.33s
Total Time 11.14s (± 0.49%) 11.16s (± 0.60%) +0.02s (+ 0.13%) 11.00s 11.32s
Monaco - node (v10.16.3, x64)
Memory used 340,349k (± 0.01%) 340,499k (± 0.02%) +150k (+ 0.04%) 340,339k 340,596k
Parse Time 1.45s (± 0.72%) 1.45s (± 0.73%) +0.00s (+ 0.28%) 1.43s 1.48s
Bind Time 0.73s (± 1.04%) 0.74s (± 0.98%) +0.01s (+ 0.95%) 0.73s 0.76s
Check Time 5.36s (± 0.81%) 5.45s (± 0.54%) +0.09s (+ 1.68%) 5.39s 5.52s
Emit Time 2.96s (± 0.91%) 3.06s (± 1.35%) +0.10s (+ 3.42%) 2.98s 3.15s
Total Time 10.50s (± 0.56%) 10.71s (± 0.41%) +0.20s (+ 1.91%) 10.61s 10.81s
TFS - node (v10.16.3, x64)
Memory used 304,069k (± 0.04%) 303,968k (± 0.03%) -101k (- 0.03%) 303,729k 304,161k
Parse Time 1.18s (± 0.64%) 1.19s (± 0.56%) +0.01s (+ 0.51%) 1.18s 1.20s
Bind Time 0.70s (± 0.79%) 0.70s (± 0.79%) +0.00s (+ 0.00%) 0.69s 0.71s
Check Time 4.88s (± 0.41%) 4.91s (± 0.57%) +0.03s (+ 0.64%) 4.85s 4.96s
Emit Time 3.10s (± 0.95%) 3.00s (± 1.40%) 🟩-0.10s (- 3.32%) 2.93s 3.10s
Total Time 9.86s (± 0.37%) 9.79s (± 0.63%) -0.07s (- 0.66%) 9.68s 9.96s
material-ui - node (v10.16.3, x64)
Memory used 471,543k (± 0.01%) 471,588k (± 0.02%) +46k (+ 0.01%) 471,434k 471,751k
Parse Time 1.73s (± 0.62%) 1.73s (± 0.38%) -0.00s (- 0.06%) 1.72s 1.74s
Bind Time 0.67s (± 1.02%) 0.66s (± 0.84%) -0.00s (- 0.60%) 0.65s 0.68s
Check Time 14.23s (± 0.66%) 14.23s (± 0.60%) +0.00s (+ 0.00%) 14.09s 14.43s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.63s (± 0.58%) 16.63s (± 0.55%) -0.01s (- 0.04%) 16.47s 16.85s
Angular - node (v12.1.0, x64)
Memory used 322,053k (± 0.01%) 322,133k (± 0.02%) +81k (+ 0.03%) 322,006k 322,250k
Parse Time 1.79s (± 0.33%) 1.78s (± 0.73%) -0.00s (- 0.11%) 1.76s 1.81s
Bind Time 0.82s (± 0.79%) 0.83s (± 0.72%) +0.00s (+ 0.49%) 0.81s 0.84s
Check Time 5.09s (± 0.69%) 5.12s (± 0.51%) +0.04s (+ 0.77%) 5.08s 5.19s
Emit Time 5.68s (± 0.72%) 5.93s (± 0.72%) +0.25s (+ 4.37%) 5.84s 6.03s
Total Time 13.38s (± 0.47%) 13.66s (± 0.40%) +0.29s (+ 2.14%) 13.54s 13.78s
Compiler-Unions - node (v12.1.0, x64)
Memory used 187,747k (± 0.08%) 187,685k (± 0.13%) -62k (- 0.03%) 186,968k 188,028k
Parse Time 0.77s (± 0.75%) 0.78s (± 0.77%) +0.00s (+ 0.26%) 0.76s 0.79s
Bind Time 0.53s (± 1.05%) 0.53s (± 1.32%) +0.00s (+ 0.19%) 0.51s 0.54s
Check Time 7.01s (± 0.54%) 7.07s (± 0.68%) +0.06s (+ 0.83%) 6.98s 7.19s
Emit Time 2.24s (± 1.34%) 2.27s (± 1.04%) +0.03s (+ 1.29%) 2.22s 2.32s
Total Time 10.55s (± 0.42%) 10.64s (± 0.63%) +0.09s (+ 0.84%) 10.51s 10.78s
Monaco - node (v12.1.0, x64)
Memory used 323,421k (± 0.03%) 323,482k (± 0.01%) +61k (+ 0.02%) 323,368k 323,537k
Parse Time 1.42s (± 0.59%) 1.42s (± 0.79%) +0.00s (+ 0.14%) 1.40s 1.45s
Bind Time 0.71s (± 0.66%) 0.71s (± 0.52%) +0.00s (+ 0.70%) 0.71s 0.72s
Check Time 5.17s (± 0.57%) 5.26s (± 0.49%) +0.09s (+ 1.70%) 5.19s 5.30s
Emit Time 3.03s (± 1.41%) 3.01s (± 0.69%) -0.02s (- 0.53%) 2.96s 3.06s
Total Time 10.33s (± 0.68%) 10.41s (± 0.37%) +0.08s (+ 0.75%) 10.30s 10.50s
TFS - node (v12.1.0, x64)
Memory used 288,534k (± 0.02%) 288,505k (± 0.01%) -30k (- 0.01%) 288,451k 288,564k
Parse Time 1.18s (± 0.51%) 1.20s (± 0.68%) +0.02s (+ 1.27%) 1.18s 1.22s
Bind Time 0.69s (± 0.96%) 0.69s (± 0.68%) +0.00s (+ 0.00%) 0.68s 0.70s
Check Time 4.75s (± 0.45%) 4.81s (± 0.32%) +0.06s (+ 1.18%) 4.79s 4.84s
Emit Time 3.12s (± 0.79%) 3.03s (± 0.87%) 🟩-0.10s (- 3.11%) 2.98s 3.08s
Total Time 9.75s (± 0.33%) 9.72s (± 0.37%) -0.02s (- 0.23%) 9.64s 9.80s
material-ui - node (v12.1.0, x64)
Memory used 450,262k (± 0.01%) 450,357k (± 0.02%) +95k (+ 0.02%) 450,228k 450,524k
Parse Time 1.71s (± 0.55%) 1.72s (± 0.43%) +0.01s (+ 0.76%) 1.71s 1.74s
Bind Time 0.64s (± 1.01%) 0.64s (± 0.81%) +0.00s (+ 0.47%) 0.63s 0.65s
Check Time 12.74s (± 0.39%) 12.80s (± 0.56%) +0.07s (+ 0.52%) 12.70s 12.99s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.08s (± 0.37%) 15.16s (± 0.49%) +0.08s (+ 0.53%) 15.04s 15.36s
Angular - node (v14.15.1, x64)
Memory used 320,833k (± 0.01%) 320,866k (± 0.01%) +33k (+ 0.01%) 320,786k 320,946k
Parse Time 1.79s (± 0.54%) 1.80s (± 0.43%) +0.01s (+ 0.56%) 1.77s 1.81s
Bind Time 0.87s (± 0.34%) 0.87s (± 0.92%) +0.00s (+ 0.46%) 0.85s 0.88s
Check Time 5.12s (± 0.43%) 5.15s (± 0.44%) +0.03s (+ 0.65%) 5.10s 5.20s
Emit Time 5.71s (± 0.85%) 6.03s (± 0.77%) +0.32s (+ 5.62%) 5.94s 6.15s
Total Time 13.48s (± 0.50%) 13.85s (± 0.45%) +0.37s (+ 2.71%) 13.71s 13.97s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,109k (± 0.51%) 189,519k (± 0.39%) +411k (+ 0.22%) 186,553k 189,908k
Parse Time 0.80s (± 0.93%) 0.80s (± 0.56%) -0.01s (- 0.62%) 0.79s 0.81s
Bind Time 0.56s (± 0.89%) 0.56s (± 0.59%) +0.00s (+ 0.72%) 0.55s 0.57s
Check Time 7.15s (± 0.81%) 7.18s (± 0.66%) +0.04s (+ 0.49%) 7.07s 7.30s
Emit Time 2.26s (± 0.77%) 2.27s (± 0.47%) +0.01s (+ 0.62%) 2.24s 2.29s
Total Time 10.76s (± 0.58%) 10.81s (± 0.49%) +0.05s (+ 0.45%) 10.69s 10.95s
Monaco - node (v14.15.1, x64)
Memory used 322,466k (± 0.01%) 322,559k (± 0.01%) +93k (+ 0.03%) 322,518k 322,609k
Parse Time 1.47s (± 0.52%) 1.47s (± 0.73%) +0.00s (+ 0.27%) 1.45s 1.49s
Bind Time 0.75s (± 0.77%) 0.74s (± 0.80%) -0.01s (- 0.67%) 0.73s 0.76s
Check Time 5.18s (± 0.56%) 5.22s (± 0.38%) +0.05s (+ 0.87%) 5.16s 5.26s
Emit Time 3.07s (± 0.88%) 3.06s (± 0.82%) -0.01s (- 0.36%) 3.02s 3.11s
Total Time 10.46s (± 0.51%) 10.49s (± 0.35%) +0.04s (+ 0.33%) 10.39s 10.57s
TFS - node (v14.15.1, x64)
Memory used 287,572k (± 0.01%) 287,521k (± 0.01%) -51k (- 0.02%) 287,492k 287,580k
Parse Time 1.24s (± 0.88%) 1.26s (± 2.32%) +0.02s (+ 1.53%) 1.23s 1.35s
Bind Time 0.71s (± 1.06%) 0.71s (± 0.51%) -0.00s (- 0.14%) 0.71s 0.72s
Check Time 4.81s (± 0.27%) 4.85s (± 0.57%) +0.04s (+ 0.79%) 4.78s 4.91s
Emit Time 3.21s (± 0.49%) 3.09s (± 0.95%) 🟩-0.12s (- 3.61%) 3.04s 3.19s
Total Time 9.97s (± 0.22%) 9.92s (± 0.32%) -0.06s (- 0.56%) 9.86s 10.03s
material-ui - node (v14.15.1, x64)
Memory used 448,629k (± 0.01%) 448,634k (± 0.00%) +6k (+ 0.00%) 448,596k 448,659k
Parse Time 1.78s (± 0.58%) 1.78s (± 0.64%) -0.00s (- 0.00%) 1.74s 1.79s
Bind Time 0.70s (± 0.53%) 0.70s (± 0.80%) +0.00s (+ 0.43%) 0.69s 0.71s
Check Time 13.02s (± 0.79%) 13.04s (± 0.69%) +0.02s (+ 0.16%) 12.89s 13.23s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.49s (± 0.71%) 15.52s (± 0.63%) +0.03s (+ 0.18%) 15.35s 15.73s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 44242 10
Baseline master 10

Developer Information:

Download Benchmark

@amcasey amcasey force-pushed the BufferWriteText branch from 43bcc88 to 457a7c6 Compare May 25, 2021 02:43
@amcasey
Copy link
Member Author

amcasey commented May 25, 2021

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 25, 2021 •
edited
Loading

Heya @amcasey, I've started to run the perf test suite on this PR at 457a7c6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 25, 2021

@amcasey
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..44242

Metric master 44242 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 343,844k (± 0.02%) 343,893k (± 0.02%) +49k (+ 0.01%) 343,726k 344,043k
Parse Time 1.79s (± 0.49%) 1.79s (± 0.42%) +0.00s (+ 0.06%) 1.78s 1.81s
Bind Time 0.84s (± 0.83%) 0.83s (± 0.44%) -0.01s (- 0.71%) 0.83s 0.84s
Check Time 5.22s (± 0.42%) 5.21s (± 0.42%) -0.01s (- 0.21%) 5.18s 5.28s
Emit Time 5.46s (± 0.87%) 5.83s (± 0.61%) +0.37s (+ 6.77%) 5.76s 5.95s
Total Time 13.32s (± 0.50%) 13.68s (± 0.23%) +0.35s (+ 2.66%) 13.62s 13.77s
Compiler-Unions - node (v10.16.3, x64)
Memory used 200,297k (± 0.07%) 200,376k (± 0.03%) +79k (+ 0.04%) 200,244k 200,491k
Parse Time 0.78s (± 0.51%) 0.79s (± 0.87%) +0.00s (+ 0.51%) 0.77s 0.80s
Bind Time 0.53s (± 1.76%) 0.52s (± 1.13%) -0.00s (- 0.76%) 0.51s 0.54s
Check Time 7.59s (± 0.70%) 7.51s (± 0.34%) -0.08s (- 1.08%) 7.46s 7.56s
Emit Time 2.25s (± 1.71%) 2.29s (± 1.04%) +0.05s (+ 2.09%) 2.25s 2.36s
Total Time 11.14s (± 0.49%) 11.11s (± 0.25%) -0.04s (- 0.34%) 11.05s 11.18s
Monaco - node (v10.16.3, x64)
Memory used 340,349k (± 0.01%) 340,382k (± 0.01%) +32k (+ 0.01%) 340,330k 340,487k
Parse Time 1.45s (± 0.72%) 1.44s (± 0.65%) -0.01s (- 0.69%) 1.42s 1.46s
Bind Time 0.73s (± 1.04%) 0.74s (± 0.92%) +0.01s (+ 1.36%) 0.73s 0.76s
Check Time 5.36s (± 0.81%) 5.38s (± 0.34%) +0.02s (+ 0.39%) 5.35s 5.43s
Emit Time 2.96s (± 0.91%) 3.02s (± 0.53%) +0.07s (+ 2.34%) 2.98s 3.06s
Total Time 10.50s (± 0.56%) 10.59s (± 0.20%) +0.09s (+ 0.86%) 10.55s 10.63s
TFS - node (v10.16.3, x64)
Memory used 304,069k (± 0.04%) 304,032k (± 0.02%) -37k (- 0.01%) 303,943k 304,161k
Parse Time 1.18s (± 0.64%) 1.18s (± 0.83%) -0.00s (- 0.17%) 1.16s 1.21s
Bind Time 0.70s (± 0.79%) 0.70s (± 0.57%) -0.00s (- 0.14%) 0.69s 0.71s
Check Time 4.88s (± 0.41%) 4.86s (± 0.63%) -0.02s (- 0.35%) 4.81s 4.94s
Emit Time 3.10s (± 0.95%) 2.97s (± 1.31%) 🟩-0.13s (- 4.13%) 2.90s 3.07s
Total Time 9.86s (± 0.37%) 9.71s (± 0.70%) -0.15s (- 1.49%) 9.59s 9.91s
material-ui - node (v10.16.3, x64)
Memory used 471,543k (± 0.01%) 471,574k (± 0.01%) +31k (+ 0.01%) 471,430k 471,677k
Parse Time 1.73s (± 0.62%) 1.72s (± 0.69%) -0.01s (- 0.52%) 1.70s 1.75s
Bind Time 0.67s (± 1.02%) 0.67s (± 1.22%) +0.00s (+ 0.15%) 0.65s 0.68s
Check Time 14.23s (± 0.66%) 14.18s (± 0.42%) -0.05s (- 0.37%) 14.07s 14.30s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.63s (± 0.58%) 16.57s (± 0.42%) -0.06s (- 0.38%) 16.43s 16.71s
Angular - node (v12.1.0, x64)
Memory used 322,053k (± 0.01%) 322,069k (± 0.02%) +17k (+ 0.01%) 321,896k 322,262k
Parse Time 1.79s (± 0.33%) 1.77s (± 0.50%) -0.01s (- 0.67%) 1.76s 1.79s
Bind Time 0.82s (± 0.79%) 0.82s (± 0.91%) +0.00s (+ 0.12%) 0.81s 0.84s
Check Time 5.09s (± 0.69%) 5.08s (± 0.40%) -0.00s (- 0.02%) 5.04s 5.13s
Emit Time 5.68s (± 0.72%) 5.95s (± 0.57%) +0.27s (+ 4.82%) 5.90s 6.02s
Total Time 13.38s (± 0.47%) 13.63s (± 0.24%) +0.26s (+ 1.93%) 13.54s 13.71s
Compiler-Unions - node (v12.1.0, x64)
Memory used 187,747k (± 0.08%) 187,841k (± 0.08%) +94k (+ 0.05%) 187,257k 188,070k
Parse Time 0.77s (± 0.75%) 0.77s (± 0.44%) -0.01s (- 0.78%) 0.76s 0.77s
Bind Time 0.53s (± 1.05%) 0.53s (± 0.90%) -0.00s (- 0.19%) 0.52s 0.54s
Check Time 7.01s (± 0.54%) 6.97s (± 0.44%) -0.04s (- 0.53%) 6.90s 7.03s
Emit Time 2.24s (± 1.34%) 2.27s (± 1.13%) +0.03s (+ 1.25%) 2.23s 2.33s
Total Time 10.55s (± 0.42%) 10.54s (± 0.33%) -0.01s (- 0.11%) 10.45s 10.61s
Monaco - node (v12.1.0, x64)
Memory used 323,421k (± 0.03%) 323,461k (± 0.02%) +40k (+ 0.01%) 323,335k 323,563k
Parse Time 1.42s (± 0.59%) 1.41s (± 0.42%) -0.00s (- 0.35%) 1.40s 1.43s
Bind Time 0.71s (± 0.66%) 0.72s (± 0.84%) +0.01s (+ 0.70%) 0.70s 0.73s
Check Time 5.17s (± 0.57%) 5.20s (± 0.36%) +0.03s (+ 0.48%) 5.16s 5.24s
Emit Time 3.03s (± 1.41%) 3.01s (± 0.55%) -0.02s (- 0.73%) 2.98s 3.06s
Total Time 10.33s (± 0.68%) 10.33s (± 0.28%) 0.00s ( 0.00%) 10.25s 10.40s
TFS - node (v12.1.0, x64)
Memory used 288,534k (± 0.02%) 288,526k (± 0.02%) -9k (- 0.00%) 288,400k 288,744k
Parse Time 1.18s (± 0.51%) 1.19s (± 0.63%) +0.00s (+ 0.17%) 1.17s 1.20s
Bind Time 0.69s (± 0.96%) 0.69s (± 0.75%) -0.00s (- 0.14%) 0.68s 0.70s
Check Time 4.75s (± 0.45%) 4.80s (± 0.40%) +0.05s (+ 0.99%) 4.76s 4.85s
Emit Time 3.12s (± 0.79%) 3.07s (± 1.39%) -0.05s (- 1.63%) 2.98s 3.19s
Total Time 9.75s (± 0.33%) 9.75s (± 0.51%) +0.00s (+ 0.02%) 9.65s 9.86s
material-ui - node (v12.1.0, x64)
Memory used 450,262k (± 0.01%) 450,296k (± 0.01%) +34k (+ 0.01%) 450,139k 450,413k
Parse Time 1.71s (± 0.55%) 1.71s (± 0.34%) +0.00s (+ 0.18%) 1.70s 1.73s
Bind Time 0.64s (± 1.01%) 0.64s (± 0.81%) +0.00s (+ 0.16%) 0.63s 0.65s
Check Time 12.74s (± 0.39%) 12.65s (± 0.33%) -0.08s (- 0.64%) 12.57s 12.75s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.08s (± 0.37%) 15.00s (± 0.30%) -0.08s (- 0.54%) 14.91s 15.10s
Angular - node (v14.15.1, x64)
Memory used 320,833k (± 0.01%) 320,832k (± 0.01%) -1k (- 0.00%) 320,788k 320,885k
Parse Time 1.79s (± 0.54%) 1.79s (± 0.59%) +0.01s (+ 0.34%) 1.78s 1.82s
Bind Time 0.87s (± 0.34%) 0.87s (± 0.60%) +0.00s (+ 0.35%) 0.86s 0.88s
Check Time 5.12s (± 0.43%) 5.11s (± 0.56%) -0.01s (- 0.18%) 5.05s 5.18s
Emit Time 5.71s (± 0.85%) 6.03s (± 0.81%) +0.31s (+ 5.48%) 5.91s 6.12s
Total Time 13.48s (± 0.50%) 13.80s (± 0.55%) +0.31s (+ 2.31%) 13.62s 13.95s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,109k (± 0.51%) 188,157k (± 0.64%) -951k (- 0.50%) 186,514k 189,837k
Parse Time 0.80s (± 0.93%) 0.80s (± 0.62%) -0.01s (- 0.87%) 0.79s 0.81s
Bind Time 0.56s (± 0.89%) 0.56s (± 0.89%) 0.00s ( 0.00%) 0.55s 0.57s
Check Time 7.15s (± 0.81%) 7.13s (± 0.55%) -0.02s (- 0.31%) 7.07s 7.21s
Emit Time 2.26s (± 0.77%) 2.28s (± 0.84%) +0.02s (+ 1.02%) 2.25s 2.34s
Total Time 10.76s (± 0.58%) 10.75s (± 0.39%) -0.01s (- 0.08%) 10.67s 10.84s
Monaco - node (v14.15.1, x64)
Memory used 322,466k (± 0.01%) 322,502k (± 0.01%) +35k (+ 0.01%) 322,431k 322,535k
Parse Time 1.47s (± 0.52%) 1.46s (± 0.42%) -0.01s (- 0.41%) 1.45s 1.47s
Bind Time 0.75s (± 0.77%) 0.74s (± 0.67%) -0.01s (- 0.67%) 0.74s 0.76s
Check Time 5.18s (± 0.56%) 5.16s (± 0.48%) -0.01s (- 0.27%) 5.12s 5.21s
Emit Time 3.07s (± 0.88%) 3.05s (± 0.71%) -0.02s (- 0.65%) 3.02s 3.11s
Total Time 10.46s (± 0.51%) 10.42s (± 0.40%) -0.04s (- 0.37%) 10.35s 10.52s
TFS - node (v14.15.1, x64)
Memory used 287,572k (± 0.01%) 287,549k (± 0.01%) -23k (- 0.01%) 287,509k 287,586k
Parse Time 1.24s (± 0.88%) 1.25s (± 2.00%) +0.01s (+ 0.81%) 1.21s 1.32s
Bind Time 0.71s (± 1.06%) 0.71s (± 0.42%) -0.00s (- 0.42%) 0.71s 0.72s
Check Time 4.81s (± 0.27%) 4.83s (± 0.56%) +0.02s (+ 0.33%) 4.78s 4.89s
Emit Time 3.21s (± 0.49%) 3.06s (± 0.57%) 🟩-0.15s (- 4.80%) 3.02s 3.10s
Total Time 9.97s (± 0.22%) 9.85s (± 0.32%) -0.13s (- 1.30%) 9.76s 9.93s
material-ui - node (v14.15.1, x64)
Memory used 448,629k (± 0.01%) 448,642k (± 0.01%) +14k (+ 0.00%) 448,585k 448,713k
Parse Time 1.78s (± 0.58%) 1.77s (± 0.38%) -0.00s (- 0.22%) 1.76s 1.79s
Bind Time 0.70s (± 0.53%) 0.69s (± 0.43%) -0.01s (- 1.01%) 0.68s 0.69s
Check Time 13.02s (± 0.79%) 12.94s (± 0.28%) -0.08s (- 0.58%) 12.88s 13.05s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.49s (± 0.71%) 15.40s (± 0.24%) -0.08s (- 0.55%) 15.34s 15.52s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 44242 10
Baseline master 10

Developer Information:

Download Benchmark

@amcasey
Copy link
Member Author

amcasey commented May 25, 2021 •
edited
Loading

This appears to have cut memory allocations by ~10% in the target internal project.

Edit: Interestingly, the time improvement is much smaller - closer to 1%. Maybe that's because emit is at the end of the pipeline and doesn't really need to be cleaned up before the process exits?

@amcasey
Copy link
Member Author

amcasey commented May 25, 2021

I switched back from join to concatenation and the allocation win went away.

@dmichon-msft
Copy link
Contributor

dmichon-msft commented May 25, 2021

How's the perf if you only replace the computeLineStarts() call with a scan for count and last line start position?

@amcasey
Copy link
Member Author

amcasey commented May 25, 2021 •
edited
Loading

Optimizing the slow case (i.e. when you need to do line math) isn't very worthwhile since it's so rare.

The speed win comes from not calling computeLineStarts and the memory win comes from using join, rather than concatenation (AFAICT).

@amcasey amcasey marked this pull request as ready for review May 25, 2021 21:58
@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 15, 2022

@amcasey
Great news! no new errors were found between main..refs/pull/44242/merge

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Feb 15, 2022

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 15, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 457a7c6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 15, 2022

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..44242

Metric main 44242 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 356,729k (± 0.01%) 356,758k (± 0.03%) +29k (+ 0.01%) 356,578k 356,945k
Parse Time 1.95s (± 0.53%) 1.95s (± 0.57%) +0.00s (+ 0.10%) 1.93s 1.98s
Bind Time 0.86s (± 0.93%) 0.86s (± 0.75%) 0.00s ( 0.00%) 0.84s 0.87s
Check Time 5.68s (± 0.48%) 5.67s (± 0.60%) -0.01s (- 0.19%) 5.58s 5.71s
Emit Time 5.91s (± 0.39%) 6.30s (± 0.42%) +0.39s (+ 6.58%) 6.26s 6.36s
Total Time 14.39s (± 0.32%) 14.78s (± 0.32%) +0.38s (+ 2.65%) 14.66s 14.87s
Compiler-Unions - node (v10.16.3, x64)
Memory used 205,529k (± 0.04%) 205,498k (± 0.03%) -30k (- 0.01%) 205,339k 205,600k
Parse Time 0.79s (± 0.75%) 0.78s (± 0.87%) -0.01s (- 1.26%) 0.77s 0.80s
Bind Time 0.53s (± 1.13%) 0.53s (± 1.13%) 0.00s ( 0.00%) 0.51s 0.54s
Check Time 7.83s (± 0.44%) 7.81s (± 0.47%) -0.01s (- 0.17%) 7.73s 7.90s
Emit Time 2.49s (± 0.98%) 2.52s (± 0.63%) +0.03s (+ 1.16%) 2.50s 2.58s
Total Time 11.64s (± 0.42%) 11.65s (± 0.42%) +0.01s (+ 0.09%) 11.55s 11.79s
Monaco - node (v10.16.3, x64)
Memory used 343,194k (± 0.02%) 343,265k (± 0.01%) +70k (+ 0.02%) 343,141k 343,358k
Parse Time 1.49s (± 0.32%) 1.49s (± 0.58%) +0.00s (+ 0.07%) 1.47s 1.51s
Bind Time 0.75s (± 0.79%) 0.76s (± 1.02%) +0.01s (+ 0.93%) 0.75s 0.78s
Check Time 5.59s (± 0.80%) 5.57s (± 0.52%) -0.02s (- 0.30%) 5.50s 5.62s
Emit Time 3.22s (± 1.12%) 3.27s (± 0.67%) +0.04s (+ 1.33%) 3.23s 3.32s
Total Time 11.06s (± 0.34%) 11.09s (± 0.39%) +0.03s (+ 0.30%) 11.01s 11.19s
TFS - node (v10.16.3, x64)
Memory used 304,999k (± 0.02%) 305,031k (± 0.02%) +32k (+ 0.01%) 304,903k 305,163k
Parse Time 1.20s (± 0.69%) 1.20s (± 0.83%) +0.00s (+ 0.33%) 1.18s 1.22s
Bind Time 0.72s (± 0.80%) 0.71s (± 0.70%) -0.01s (- 0.69%) 0.70s 0.72s
Check Time 5.13s (± 0.52%) 5.14s (± 0.42%) +0.01s (+ 0.16%) 5.09s 5.18s
Emit Time 3.38s (± 1.01%) 3.32s (± 1.57%) -0.06s (- 1.66%) 3.22s 3.43s
Total Time 10.43s (± 0.31%) 10.38s (± 0.66%) -0.05s (- 0.46%) 10.23s 10.52s
material-ui - node (v10.16.3, x64)
Memory used 468,762k (± 0.01%) 468,811k (± 0.02%) +49k (+ 0.01%) 468,671k 469,003k
Parse Time 1.78s (± 0.26%) 1.79s (± 0.42%) +0.01s (+ 0.39%) 1.77s 1.81s
Bind Time 0.66s (± 1.14%) 0.67s (± 1.11%) +0.01s (+ 1.20%) 0.66s 0.69s
Check Time 14.03s (± 0.30%) 14.06s (± 0.37%) +0.02s (+ 0.17%) 13.95s 14.15s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.48s (± 0.29%) 16.52s (± 0.34%) +0.04s (+ 0.24%) 16.40s 16.63s
xstate - node (v10.16.3, x64)
Memory used 570,644k (± 0.01%) 570,613k (± 0.01%) -31k (- 0.01%) 570,411k 570,767k
Parse Time 2.55s (± 0.36%) 2.55s (± 0.23%) +0.00s (+ 0.16%) 2.54s 2.57s
Bind Time 1.02s (± 0.29%) 1.02s (± 0.56%) +0.00s (+ 0.20%) 1.01s 1.03s
Check Time 1.48s (± 0.55%) 1.48s (± 0.59%) 0.00s ( 0.00%) 1.47s 1.50s
Emit Time 0.07s (± 4.13%) 0.07s (± 4.13%) 0.00s ( 0.00%) 0.07s 0.08s
Total Time 5.12s (± 0.22%) 5.12s (± 0.24%) -0.00s (- 0.06%) 5.09s 5.14s
Angular - node (v12.1.0, x64)
Memory used 334,499k (± 0.03%) 334,472k (± 0.01%) -27k (- 0.01%) 334,379k 334,561k
Parse Time 1.96s (± 0.64%) 1.95s (± 0.61%) -0.02s (- 0.87%) 1.91s 1.96s
Bind Time 0.84s (± 0.40%) 0.84s (± 1.06%) +0.01s (+ 0.60%) 0.83s 0.87s
Check Time 5.46s (± 0.54%) 5.47s (± 0.26%) +0.00s (+ 0.05%) 5.44s 5.50s
Emit Time 6.15s (± 0.54%) 6.47s (± 0.64%) +0.33s (+ 5.31%) 6.38s 6.60s
Total Time 14.41s (± 0.37%) 14.73s (± 0.34%) +0.32s (+ 2.23%) 14.63s 14.87s
Compiler-Unions - node (v12.1.0, x64)
Memory used 193,011k (± 0.08%) 192,937k (± 0.14%) -74k (- 0.04%) 192,031k 193,218k
Parse Time 0.78s (± 0.75%) 0.78s (± 0.51%) +0.00s (+ 0.26%) 0.77s 0.79s
Bind Time 0.53s (± 0.68%) 0.54s (± 0.96%) +0.01s (+ 0.94%) 0.53s 0.55s
Check Time 7.33s (± 0.58%) 7.34s (± 0.87%) +0.02s (+ 0.25%) 7.26s 7.53s
Emit Time 2.50s (± 0.84%) 2.53s (± 1.30%) +0.03s (+ 1.08%) 2.47s 2.65s
Total Time 11.14s (± 0.53%) 11.19s (± 0.63%) +0.05s (+ 0.46%) 11.07s 11.36s
Monaco - node (v12.1.0, x64)
Memory used 326,084k (± 0.06%) 326,075k (± 0.08%) -9k (- 0.00%) 325,017k 326,356k
Parse Time 1.46s (± 0.50%) 1.48s (± 0.88%) +0.01s (+ 0.96%) 1.45s 1.50s
Bind Time 0.74s (± 0.88%) 0.73s (± 0.65%) -0.01s (- 0.68%) 0.72s 0.74s
Check Time 5.49s (± 0.46%) 5.48s (± 0.38%) -0.01s (- 0.16%) 5.41s 5.51s
Emit Time 3.23s (± 1.37%) 3.26s (± 0.91%) +0.02s (+ 0.77%) 3.20s 3.31s
Total Time 10.92s (± 0.43%) 10.94s (± 0.53%) +0.02s (+ 0.17%) 10.80s 11.06s
TFS - node (v12.1.0, x64)
Memory used 289,718k (± 0.03%) 289,707k (± 0.02%) -11k (- 0.00%) 289,578k 289,863k
Parse Time 1.22s (± 0.71%) 1.22s (± 0.68%) -0.01s (- 0.49%) 1.20s 1.23s
Bind Time 0.70s (± 0.97%) 0.70s (± 0.95%) -0.01s (- 0.71%) 0.69s 0.71s
Check Time 5.05s (± 0.26%) 5.11s (± 0.48%) +0.05s (+ 1.07%) 5.05s 5.15s
Emit Time 3.43s (± 0.39%) 3.35s (± 0.56%) -0.08s (- 2.30%) 3.31s 3.40s
Total Time 10.41s (± 0.22%) 10.37s (± 0.40%) -0.04s (- 0.36%) 10.30s 10.46s
material-ui - node (v12.1.0, x64)
Memory used 447,801k (± 0.07%) 447,967k (± 0.01%) +166k (+ 0.04%) 447,845k 448,041k
Parse Time 1.78s (± 0.41%) 1.79s (± 0.46%) +0.01s (+ 0.62%) 1.77s 1.81s
Bind Time 0.64s (± 0.87%) 0.64s (± 0.81%) +0.00s (+ 0.47%) 0.63s 0.65s
Check Time 12.66s (± 0.70%) 12.68s (± 0.54%) +0.02s (+ 0.15%) 12.56s 12.81s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.08s (± 0.57%) 15.11s (± 0.48%) +0.03s (+ 0.23%) 14.99s 15.26s
xstate - node (v12.1.0, x64)
Memory used 536,520k (± 0.02%) 536,516k (± 0.01%) -4k (- 0.00%) 536,391k 536,684k
Parse Time 2.49s (± 0.42%) 2.49s (± 0.29%) -0.00s (- 0.16%) 2.48s 2.51s
Bind Time 1.05s (± 0.57%) 1.05s (± 0.55%) +0.01s (+ 0.67%) 1.04s 1.07s
Check Time 1.43s (± 0.33%) 1.44s (± 0.69%) +0.01s (+ 0.70%) 1.42s 1.46s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.04s (± 0.25%) 5.05s (± 0.38%) +0.02s (+ 0.32%) 5.02s 5.12s
Angular - node (v14.15.1, x64)
Memory used 332,801k (± 0.01%) 332,837k (± 0.01%) +36k (+ 0.01%) 332,768k 332,877k
Parse Time 1.95s (± 0.39%) 1.96s (± 0.51%) +0.00s (+ 0.15%) 1.93s 1.98s
Bind Time 0.89s (± 0.45%) 0.89s (± 0.66%) +0.01s (+ 0.56%) 0.88s 0.91s
Check Time 5.50s (± 0.43%) 5.52s (± 0.27%) +0.02s (+ 0.40%) 5.50s 5.57s
Emit Time 6.23s (± 0.81%) 6.55s (± 0.46%) +0.32s (+ 5.15%) 6.51s 6.64s
Total Time 14.58s (± 0.40%) 14.93s (± 0.28%) +0.35s (+ 2.41%) 14.85s 15.02s
Compiler-Unions - node (v14.15.1, x64)
Memory used 194,927k (± 0.02%) 192,687k (± 0.57%) -2,239k (- 1.15%) 191,674k 194,985k
Parse Time 0.81s (± 0.45%) 0.80s (± 0.37%) -0.00s (- 0.50%) 0.80s 0.81s
Bind Time 0.56s (± 0.71%) 0.56s (± 0.53%) +0.00s (+ 0.18%) 0.56s 0.57s
Check Time 7.43s (± 1.04%) 7.40s (± 0.75%) -0.02s (- 0.31%) 7.30s 7.54s
Emit Time 2.47s (± 0.52%) 2.49s (± 0.62%) +0.02s (+ 0.77%) 2.46s 2.53s
Total Time 11.27s (± 0.70%) 11.26s (± 0.54%) -0.00s (- 0.03%) 11.13s 11.40s
Monaco - node (v14.15.1, x64)
Memory used 325,014k (± 0.00%) 325,008k (± 0.01%) -7k (- 0.00%) 324,963k 325,067k
Parse Time 1.50s (± 0.45%) 1.51s (± 0.62%) +0.00s (+ 0.27%) 1.49s 1.53s
Bind Time 0.77s (± 0.58%) 0.77s (± 0.84%) +0.00s (+ 0.52%) 0.76s 0.79s
Check Time 5.37s (± 0.39%) 5.39s (± 0.30%) +0.02s (+ 0.34%) 5.36s 5.44s
Emit Time 3.29s (± 1.23%) 3.31s (± 0.65%) +0.02s (+ 0.58%) 3.26s 3.35s
Total Time 10.93s (± 0.50%) 10.98s (± 0.28%) +0.04s (+ 0.40%) 10.90s 11.04s
TFS - node (v14.15.1, x64)
Memory used 288,522k (± 0.01%) 288,516k (± 0.01%) -6k (- 0.00%) 288,484k 288,561k
Parse Time 1.23s (± 0.40%) 1.24s (± 0.63%) +0.01s (+ 1.06%) 1.22s 1.26s
Bind Time 0.74s (± 1.05%) 0.74s (± 0.88%) -0.00s (- 0.14%) 0.73s 0.75s
Check Time 5.07s (± 0.36%) 5.08s (± 0.40%) +0.02s (+ 0.34%) 5.04s 5.13s
Emit Time 3.51s (± 1.23%) 3.43s (± 1.40%) -0.09s (- 2.50%) 3.34s 3.56s
Total Time 10.55s (± 0.38%) 10.49s (± 0.53%) -0.06s (- 0.60%) 10.40s 10.66s
material-ui - node (v14.15.1, x64)
Memory used 446,154k (± 0.00%) 446,164k (± 0.00%) +10k (+ 0.00%) 446,121k 446,232k
Parse Time 1.84s (± 0.70%) 1.84s (± 0.59%) +0.00s (+ 0.27%) 1.82s 1.87s
Bind Time 0.68s (± 0.44%) 0.69s (± 0.75%) +0.01s (+ 1.03%) 0.68s 0.70s
Check Time 12.69s (± 0.42%) 12.77s (± 0.59%) +0.07s (+ 0.56%) 12.67s 13.03s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.21s (± 0.38%) 15.29s (± 0.51%) +0.08s (+ 0.53%) 15.19s 15.56s
xstate - node (v14.15.1, x64)
Memory used 534,303k (± 0.01%) 534,344k (± 0.00%) +41k (+ 0.01%) 534,288k 534,375k
Parse Time 2.56s (± 0.41%) 2.56s (± 0.66%) 0.00s ( 0.00%) 2.52s 2.59s
Bind Time 1.16s (± 0.77%) 1.17s (± 0.71%) +0.01s (+ 0.87%) 1.15s 1.18s
Check Time 1.47s (± 0.27%) 1.47s (± 0.46%) +0.01s (+ 0.34%) 1.46s 1.49s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.26s (± 0.18%) 5.27s (± 0.44%) +0.01s (+ 0.29%) 5.23s 5.34s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory5 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 44242 10
Baseline main 10

Developer Information:

Download Benchmark

@microsoft microsoft deleted a comment from typescript-bot Jun 29, 2022
@microsoft microsoft deleted a comment from typescript-bot Jun 29, 2022
@amcasey
Copy link
Member Author

amcasey commented Jul 22, 2022 •
edited
Loading

Markdown test

Successfully analyzed 1 of 3 visited repos
Outcome Count
PackageInstallFailed 2
NewBuildHadErrors 1

@amcasey
Copy link
Member Author

amcasey commented Sep 13, 2022

@typescript-bot user test this
@typescript-bot test top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 13, 2022 •
edited
Loading

Heya @amcasey, I've started to run the diff-based user code test suite on this PR at 457a7c6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 13, 2022 •
edited
Loading

Heya @amcasey, I've started to run the diff-based top-repos suite on this PR at 457a7c6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 13, 2022

@amcasey Here are the results of running the user test suite comparing main and refs/pull/44242/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 13, 2022

@amcasey Here are the results of running the top-repos suite comparing main and refs/pull/44242/merge:

Everything looks good!

@amcasey
Copy link
Member Author

amcasey commented Sep 21, 2022

@typescript-bot user test tsserver
@typescript-bot test tsserver top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022 •
edited
Loading

Heya @amcasey, I've started to run the diff-based user code test suite (tsserver) on this PR at 457a7c6. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022 •
edited
Loading

Heya @amcasey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 457a7c6. You can monitor the build here.

@amcasey
Copy link
Member Author

amcasey commented Sep 21, 2022

@typescript-bot user test tsserver
@typescript-bot test tsserver top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022 •
edited
Loading

Heya @amcasey, I've started to run the diff-based user code test suite (tsserver) on this PR at 457a7c6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022 •
edited
Loading

Heya @amcasey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 457a7c6. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022

@amcasey Here are the results of running the user test suite comparing main and refs/pull/44242/merge:

Everything looks good!

@amcasey
Copy link
Member Author

amcasey commented Sep 21, 2022

@typescript-bot test tsserver top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022 •
edited
Loading

Heya @amcasey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 457a7c6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 21, 2022

@amcasey Here are the results of running the top-repos suite comparing main and refs/pull/44242/merge:

Something interesting changed - please have a look.

Details

palantir/blueprint

⚠️ Note that built also had errors ⚠️ 
Req #12972 - references
    at formatMessage (/typescript-main/built/local/tsserver.js:178768:29)
    at IOSession.Session.writeMessage (/typescript-main/built/local/tsserver.js:179843:31)
    at IOSession.Session.send (/typescript-main/built/local/tsserver.js:179840:22)
    at IOSession.Session.doOutput (/typescript-main/built/local/tsserver.js:179893:22)
    at IOSession.Session.onMessage (/typescript-main/built/local/tsserver.js:181539:30)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:185646:31)

Req #12972 - references
    at formatMessage (/typescript-44242/built/local/tsserver.js:178810:29)
    at IOSession.Session.writeMessage (/typescript-44242/built/local/tsserver.js:179885:31)
    at IOSession.Session.send (/typescript-44242/built/local/tsserver.js:179882:22)
    at IOSession.Session.doOutput (/typescript-44242/built/local/tsserver.js:179935:22)
    at IOSession.Session.onMessage (/typescript-44242/built/local/tsserver.js:181581:30)
    at Interface.<anonymous> (/typescript-44242/built/local/tsserver.js:185688:31)

Last few requests

 
{"seq":12969,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":478847,"entryNames":["_"]}}
{"seq":12970,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":478865,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":12971,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":478865,"entryNames":["_"]}}
{"seq":12972,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":480730}}

Repro Steps
  1. git clone https://github.com/palantir/blueprint --recurse-submodules
  2. In dir blueprint, run git reset --hard 6e91675a9f75232e464863c7c3437ab504c33dc5
  3. In dir blueprint, run yarn install --silent --ignore-engines --ignore-scripts --silent
  4. Download RepoResults4/palantir.blueprint.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js

@jakebailey jakebailey mentioned this pull request Sep 6, 2023
Closed
@jakebailey
Copy link
Member

jakebailey commented Jan 20, 2024

Closing in favor of #55657.

@jakebailey jakebailey closed this Jan 20, 2024
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 16, 2025

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees

@amcasey amcasey

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amcasey @typescript-bot @dmichon-msft @DanielRosenwasser @jakebailey