-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Format function type (and others) #4442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format function type (and others) #4442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also add:
- ConstructorType
- ConstructSignature
- CallSignature
- ParenthesizedType
- TaggedTemplateExpression
- AwaitExpression
- YieldExpression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and add tests for theses :)
|
@mhegazy I think most of the types are now covered except YieldExpression. Do you have an example that is not being properly formatted? |
|
👍 |
Format function type (and others)
|
Thanks @saschanaz! @mhegazy should this be brought into 1.6 as well? |
Fixes #4438
and (maybe) #4486.Async-await current:
Fix:
Function type / Constructor type current:
Fix:
Parenthesized type current:
Fix:
Call/Constructor/Method signature current:
(Constructor signature only is covered)
Fix:
Tagged template string current:
Fix:
Type alias current:
Fix:
Type union current:
Fix: