Skip to content

Conversation

@gwicksted
Copy link
Contributor

Also added missing option in Intl.DateTimeFormatOptions (timeZone). Original ticket #4294

Also added missing option in Intl.DateTimeFormatOptions (timeZone).  Original ticket #4294
@msftclas
Copy link

Hi @gwicksted, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@zhengbli
Copy link
Contributor

What about toLocaleTimeString overloads? Should that be added as well?

@gwicksted
Copy link
Contributor Author

@zhengbli yes, I suppose it should! Added to the existing patch-1 branch.

@mhegazy
Copy link
Contributor

mhegazy commented Sep 2, 2015

👍

zhengbli added a commit that referenced this pull request Sep 2, 2015
Add parameters to toLocaleDateString
@zhengbli zhengbli merged commit 690b87c into microsoft:master Sep 2, 2015
@zhengbli
Copy link
Contributor

zhengbli commented Sep 2, 2015

@gwicksted Thanks for your contribution!

zhengbli added a commit to zhengbli/TypeScript that referenced this pull request Sep 3, 2015
Add parameters to toLocaleDateString
@gwicksted gwicksted deleted the patch-1 branch September 4, 2015 15:54
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants