Allow referencing type-only exports as namespace members in ImportTypes and TypeQueries #49056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and TypeQueries
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
commented
May 10, 2022
| }; | ||
| //// [button.d.ts] | ||
| export declare const c: { | ||
| directive: typeof import("./lit.js").ClassMapDirective; |
Member
Author
There was a problem hiding this comment.
This is what declaration emit has always done, but was an error until now.
DanielRosenwasser
approved these changes
May 11, 2022
Member
DanielRosenwasser
left a comment
DanielRosenwasser
left a comment
There was a problem hiding this comment.
Seems reasonable. I'm surprised it was that that easy to plumb through.
| return isErrorType(apparentType) ? errorType : apparentType;; | ||
| } | ||
| prop = getPropertyOfType(apparentType, right.escapedText); | ||
| prop = getPropertyOfType(apparentType, right.escapedText, /*skipObjectFunctionPropertyAugment*/ false, /*includeTypeOnlyMembers*/ node.kind === SyntaxKind.QualifiedName); |
Member
There was a problem hiding this comment.
Nit: is there a reason why here you used /*skipObjectFunctionPropertyAugment*/ false but above you use undefined?
Member
Author
There was a problem hiding this comment.
Just to see if you were paying attention
src/compiler/checker.ts
Outdated
| @@ -28997,7 +28999,7 @@ namespace ts { | |||
| } | |||
| return isErrorType(apparentType) ? errorType : apparentType;; | |||
Member
There was a problem hiding this comment.
I sent a quick fix for this.
Member
Author
There was a problem hiding this comment.
I don’t recall seeing this or touching this line. Weird.
Member
Author
There was a problem hiding this comment.
Oh, it’s because you did
weswigham
approved these changes
May 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45946