Make watch/FS testing code friendlier for project loading in module transformation #49087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
changed the title
src/compiler/watch.ts
Outdated
| PackageJson: "package.json file", | ||
|
|
||
| // Additional tsserver specific watch information | ||
| /* @internal */ |
Member
There was a problem hiding this comment.
Everything in this file is already internal ?
Member
Author
There was a problem hiding this comment.
So it is, oops. I could have sworn it wasn't on my branch (maybe an error in my transformer code).
Now I'm even more compelled to make this an enum.
sheetalkamat
approved these changes
May 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes that let me load all of TS into a single project for doing the module transformation without checker errors:
FSEntryin the test harness code; this type is indirectly returned from the public functionsnap, anddeclaration: true(which we need for composite) is incompatible. Exporting it makes TS happy.tsserver's internalWatchTypeRegistryextras intocompiler; this kind of augmentation prevents loading of everything as one project, and it turns out that this code was incorrect because it forgot to assignNodeModulesForModuleSpecifierCacheto the object. Maybe this just needs to be an enum or something, rather than writing everything twice,but it's unfortunately already exported.